Patroni pre-checks: check etcd cluster accessible #476
+32
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suggest checking the network availability of the etcd cluster before adding nodes to the Patroni cluster. If etcd is unavailable for some reason, don't even attempt to add the node.
I created the role patroni/pre-checks for this purpose and added it to the playbooks deploy_pgcluster.yml and add_pgnode.yml.
I considered adding this checks to other playbooks but decided it might hinder the administrator from updating the cluster in some situations, which could be unsafe.