Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure retrieval of hugepage size in check mode #814

Merged
merged 4 commits into from
Nov 22, 2024
Merged

Conversation

vitabaks
Copy link
Owner

@vitabaks vitabaks commented Nov 22, 2024

This update adds check_mode: false to the tasks retrieving Hugepagesize and HugePages_Total values from /proc/meminfo. This ensures these tasks are executed even in Ansible’s check mode, allowing necessary data to be consistently retrieved for subsequent calculations.

Before:

TASK [pre-checks : HugePages | info] *******************************************
ok: [172.30.58.35] => {
    "msg": {
        "huge_page_size_kb": "0",
        "huge_pages_required": "16896",
        "huge_pages_sufficient": false,
        "huge_pages_total": "0",
        "shared_buffers_gb": "32"
    }
}

After:

TASK [pre-checks : HugePages | info] *******************************************
ok: [172.30.58.35] => {
    "msg": {
        "huge_page_size_kb": "2048",
        "huge_pages_required": "16896",
        "huge_pages_sufficient": false,
        "huge_pages_total": "19020",
        "shared_buffers_gb": "32"
    }
}

Ensure HugePages parameters are always retrieved regardless of shared_buffers size
@vitabaks vitabaks self-assigned this Nov 22, 2024
@vitabaks vitabaks changed the title Ensure HugePages parameters are always retrieved Ensure retrieval of Hugepagesize and HugePages_Total in Ansible check mode Nov 22, 2024
@vitabaks vitabaks changed the title Ensure retrieval of Hugepagesize and HugePages_Total in Ansible check mode Ensure retrieval of hugepage size in Ansible check mode Nov 22, 2024
@vitabaks vitabaks changed the title Ensure retrieval of hugepage size in Ansible check mode Ensure retrieval of hugepage size in check mode Nov 22, 2024
@vitabaks vitabaks merged commit 471d474 into master Nov 22, 2024
16 checks passed
@vitabaks vitabaks deleted the huge-pages branch November 22, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant