Adding support for FreeBSD and bash location discovery via env #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yne
reviewed
Nov 2, 2019
| @@ -8,7 +8,7 @@ install_vitasdk () { | |||
| INSTALLDIR=$1 | |||
|
|
|||
| case "$(uname -s)" in | |||
| Darwin*) | |||
| Darwin*|FreeBSD*) | |||
There was a problem hiding this comment.
is *BSD* also fine (NetBSD, OpenBSD, PC-BSD) ?
There was a problem hiding this comment.
Well, I tried in FreeNAS and FreeBSD, and it was exactly FreeBSD, so *BSD may be a better solution.
|
hm...after the patch, |
|
Actually we need more than that.. The binaries downloaded with osx is not fully compatible with FreeBSD. While OSX is also FreeBSD based the it seems there is enough difference that binaries are not executable on FreeBSD systems. |
|
yes, a best option is making the package for the bsd version :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OSX is FreeBSD based, so I added FreeBSD.
Instead of assuming bash is located in /bin folder, I changed it to autodetect via env command which exists in every linux/freebsd system in /usr/bin folder. This way even if it's installed later to /usr/local/bin etc.. this will correctly find where the bash is.