Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add NIDs from other sources #86

Closed
wants to merge 7 commits into from

Conversation

xerpi
Copy link
Contributor

@xerpi xerpi commented Nov 12, 2016

  • wiki.henkaku.xyz
  • "Vita NIDs pastebin"
  • prettify db

Info: used https://gist.github.com/xerpi/eb49b34f7bc43f90194c0a16bbf0e623 to "link" the jsons DB together

@xerpi xerpi changed the title Add NIDs from wiki.henkaku.xyz Add NIDs from wiki.henkaku.xyz, NIDs pastebin, prettify db Nov 12, 2016
@xerpi xerpi changed the title Add NIDs from wiki.henkaku.xyz, NIDs pastebin, prettify db Add NIDs from wiki.henkaku.xyz, "Vita NIDs pastebin", prettify db Nov 12, 2016
@d3m3vilurr
Copy link
Contributor

well... i'm following commits, have any reason about change tab char in 276c2e2? it make to change all lines, then cannot check diff..

@d3m3vilurr
Copy link
Contributor

anything else LGTM. need you more personal check (like duplicate value check using tool)? if need, i'll make checking script.

@xerpi
Copy link
Contributor Author

xerpi commented Nov 12, 2016

276c2e2 sorts all the entries, so it's very difficult to see the changes easily anyways.

@d3m3vilurr
Copy link
Contributor

d3m3vilurr commented Nov 12, 2016

if one commit have only one action(in this case just sort) i can ignore just that commit
also they still can be diff, but indent change can't.
if reason is match other header files (they use hardtab), i can allow that.
but another reason like reduce file size, i can't understand. hm...but yeah, it's little things
so i'm ok this patch, but i'll make checking script for the automatic compare old db values and check entry duplication.
or if you already checked thase, please notice to me. i'll just merge this.

@xerpi
Copy link
Contributor Author

xerpi commented Nov 12, 2016

Do not merge yet, there's a a nid duplication problem:
xerpi�: why the hell did Sony put some sceIo functions to SceLibKernel?�
xerpi�: on 1.69 those functions are on SceIofilemgr�
xerpi�: but on 3.60 for example, they're in SceLibKernel�
xerpi: same with threadmgr functions�

@d3m3vilurr d3m3vilurr changed the title Add NIDs from wiki.henkaku.xyz, "Vita NIDs pastebin", prettify db [WIP] Add NIDs from wiki.henkaku.xyz, "Vita NIDs pastebin", prettify db Nov 12, 2016
@d3m3vilurr
Copy link
Contributor

https://gist.github.com/d3m3vilurr/034169e6ea137bad24b8cf433cdd93a6 quick&dirty check.
@xerpi yeah.. it's weird :(

@d3m3vilurr d3m3vilurr changed the title [WIP] Add NIDs from wiki.henkaku.xyz, "Vita NIDs pastebin", prettify db [WIP] Add NIDs from other sources Nov 12, 2016
@xerpi
Copy link
Contributor Author

xerpi commented Nov 12, 2016

The problem is that I added NIDs from the wiki, but those NIDs are the 1.69 ones, and some of them are in another module now on 3.x.

@@ -2503,7 +2503,6 @@
"sceKernelCancelMsgPipe": 3463879811,
"sceKernelCancelMutex": 460639113,
"sceKernelCancelMutex_089": 1912911942,
Copy link
Member

@devnoname120 devnoname120 Nov 13, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does the suffix _89 mean?

@d3m3vilurr d3m3vilurr mentioned this pull request Nov 21, 2016
3 tasks
@yifanlu
Copy link
Contributor

yifanlu commented Dec 7, 2016

We should also get module nids from the wiki. Since module nids change per fw version, we use 1.69 if possible. Then, optionally, we can use the yaml overlay to add module nids for other fw versions.

@devnoname120
Copy link
Member

devnoname120 commented Dec 7, 2016

This pull request is outdated since we switched to YAML. In addition, it has unresolvable conflicts because it has sorted the database.

Someone should create a new pull request and post the code (preferably Python) to produce each step, so that we can proof-check the code rather than the result.

@devnoname120
Copy link
Member

devnoname120 commented Dec 7, 2016

And so that we don't forget about this: #108.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants