-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Add NIDs from other sources #86
Conversation
well... i'm following commits, have any reason about change tab char in 276c2e2? it make to change all lines, then cannot check diff.. |
anything else LGTM. need you more personal check (like duplicate value check using tool)? if need, i'll make checking script. |
276c2e2 sorts all the entries, so it's very difficult to see the changes easily anyways. |
if one commit have only one action(in this case just sort) i can ignore just that commit |
Do not merge yet, there's a a nid duplication problem: |
https://gist.github.com/d3m3vilurr/034169e6ea137bad24b8cf433cdd93a6 quick&dirty check. |
The problem is that I added NIDs from the wiki, but those NIDs are the 1.69 ones, and some of them are in another module now on 3.x. |
@@ -2503,7 +2503,6 @@ | |||
"sceKernelCancelMsgPipe": 3463879811, | |||
"sceKernelCancelMutex": 460639113, | |||
"sceKernelCancelMutex_089": 1912911942, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does the suffix _89
mean?
We should also get module nids from the wiki. Since module nids change per fw version, we use 1.69 if possible. Then, optionally, we can use the yaml overlay to add module nids for other fw versions. |
This pull request is outdated since we switched to YAML. In addition, it has unresolvable conflicts because it has sorted the database. Someone should create a new pull request and post the code (preferably Python) to produce each step, so that we can proof-check the code rather than the result. |
And so that we don't forget about this: #108. |
Info: used https://gist.github.com/xerpi/eb49b34f7bc43f90194c0a16bbf0e623 to "link" the jsons DB together