Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jquery 3.5.0 Security Fix Closing HTML Tags #376

Closed
melloware opened this issue Jun 24, 2020 · 4 comments
Closed

Jquery 3.5.0 Security Fix Closing HTML Tags #376

melloware opened this issue Jun 24, 2020 · 4 comments
Assignees
@illuusio
Labels
Bug fix Need testing

Comments

@melloware
Copy link

See: https://blog.jquery.com/2020/04/10/jquery-3-5-0-released/

You can't do this anymore...

$('<div class="jspVerticalBar" />')

You have to add the closing tags yourself like

$('<div class="jspVerticalBar"></div>')
@illuusio
Copy link
Collaborator

illuusio commented Jun 25, 2020 •
edited
Loading

I fix this as this appears to be in many places

illuusio added a commit that referenced this issue Jun 25, 2020
@illuusio
Fix security Issue #376 with jQuery 3.5.x
72cfc32
@illuusio
Copy link
Collaborator

This should be fixed in master now

@illuusio illuusio self-assigned this Jun 25, 2020
@melloware
Copy link
Author

Nice work! Looks good to me.

illuusio added a commit that referenced this issue Jun 25, 2020
@illuusio
For making fixing Issue #376 Complete. Rewrite example '<p />' also w…
4154b4f 
…ith syntax <p></p>'
@illuusio
Copy link
Collaborator

This can be closed then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@illuusio illuusio

Labels
Bug fix Need testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@illuusio @melloware