Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added suggested fix of @aphillips8 in #143 to update height on reinitial... #301

Closed
wants to merge 1 commit into from

Conversation

tylkomat
Copy link

...ize

@illuusio
Copy link
Collaborator

Is this still relevant and can you tell how to test this.

@tylkomat
Copy link
Author

Sorry after two years, I can't really remember. But we are using it in production for some time.

@illuusio
Copy link
Collaborator

With this patch included?

@tylkomat
Copy link
Author

Yes.

@illuusio
Copy link
Collaborator

Can you tell which kind of operation requires this patch if you can give any clues because this seems to be good formed patch? Resizing window or resizing area of pane?

@tylkomat
Copy link
Author

This is the original issue. I remember now. In our case the problem was: There is a list of items larger than the screen. Then you apply a filter to the list and the items become less and fit into a screen, but the scrollpane still has scrollbars and keeps the original height of when it was first initialized.

@illuusio
Copy link
Collaborator

Ok thanks I try to take a look at this when I have time and integrate if it feels correct

@illuusio illuusio added Help Needed If you have spare time you can test these and removed Insufficient input available labels Apr 19, 2018
@illuusio
Copy link
Collaborator

Can you test PR #361 does that fix this issue?

@illuusio
Copy link
Collaborator

This should be fixed with 2.2.0 if not please feel free to re-open.

@illuusio illuusio closed this May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug fix Help Needed If you have spare time you can test these Need testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants