Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm scripts and local dev dependencies to build the project #359

Merged
merged 3 commits into from
Apr 22, 2018
Merged

Use npm scripts and local dev dependencies to build the project #359

merged 3 commits into from
Apr 22, 2018

Conversation

abhishekdev
Copy link
Contributor

This pull request allows contributors to build the project using local development dependencies and npm.

  • Updated the README docs to reflect the new build workflow for contributors.
  • Ignored node_modules from being tracked in git

@illuusio
Copy link
Collaborator

Thank you for this. I have to test it if it work I definitely like to merge it.

@illuusio
Copy link
Collaborator

Please remove package-lock.json change and if you could add it to .gitignore

@abhishekdev
Copy link
Contributor Author

abhishekdev commented Apr 19, 2018

Hi @illuusio, I would be glad to make review changes. However for your request about package-lock.json I would like to understand why you suggest to remove it?

Here is as excerpt from npmjs.com docs (ref):

This file is intended to be committed into source repositories, and serves various purposes:

  • Describe a single representation of a dependency tree such that teammates, deployments, and continuous integration are guaranteed to install exactly the same dependencies.
  • Provide a facility for users to "time-travel" to previous states of node_modules without having to commit the directory itself.
  • To facilitate greater visibility of tree changes through readable source control diffs.
  • And optimize the installation process by allowing npm to skip repeated metadata resolutions for previously-installed packages.

@illuusio
Copy link
Collaborator

Ok it's pretty stupid to have some binary blob in repo but as it's how they roll who am I resist?

@illuusio illuusio merged commit eef9157 into vitch:master Apr 22, 2018
@abhishekdev abhishekdev deleted the feature/npm-build-script branch April 22, 2018 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants