Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix issues #54 #55

Merged
merged 2 commits into from
Sep 15, 2024
Merged

bugfix issues #54 #55

merged 2 commits into from
Sep 15, 2024

Conversation

Bowenn
Copy link

@Bowenn Bowenn commented Aug 1, 2024 •
edited by yejimeiming
Loading

Examples.

var getOwnPropertyDescriptor = require('./object-get-own-property-descriptor').f;

Add brackets.

var getOwnPropertyDescriptor = __CJS__import__0__.default || __CJS__import__0__.f   // ❌
var getOwnPropertyDescriptor = (__CJS__import__0__.default || __CJS__import__0__).f // ✅

yejimeiming
yejimeiming approved these changes Sep 15, 2024
View reviewed changes
Copy link
Member

@yejimeiming yejimeiming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@yejimeiming yejimeiming linked an issue Sep 15, 2024 that may be closed by this pull request
[bug] transed import part miss brackets, cause undefined error，转换得加个括号 #54
Closed
@yejimeiming yejimeiming merged commit af875ed into vite-plugin:main Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yejimeiming yejimeiming yejimeiming approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] transed import part miss brackets, cause undefined error，转换得加个括号
2 participants
@Bowenn @yejimeiming