Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize loading workbox::injectManifest #749

Closed
userquin opened this issue Sep 4, 2024 · 0 comments · Fixed by #750
Closed

Optimize loading workbox::injectManifest #749

userquin opened this issue Sep 4, 2024 · 0 comments · Fixed by #750
Assignees
Labels
enhancement New feature or request

Comments

@userquin
Copy link
Member

userquin commented Sep 4, 2024

If the user disables injection point, there is no need to load workbox here

const [workbox, buildSW] = await Promise.all([
loadWorkboxBuild(),
import('./vite-build').then(({ buildSW }) => buildSW),
])

We can just provide the promise to the custom vite build and await when there is injection point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant