Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(injectManifest): optimize workbox load #750

Merged
merged 3 commits into from
Sep 4, 2024

Conversation

userquin
Copy link
Member

@userquin userquin commented Sep 4, 2024

Description

This PR includes:

  • use readFileSync to load version
  • add ./package.json to package exports
  • update debug to 4.3.6
  • update @vite-pwa/assets-generator to 0.2.6
  • load workbox when using injectManifest strategy only when there is injection point
  • change maximumFileSizeToCacheInBytes error message, check screenshots below

Linked Issues

closes #749

Additional Context

imagen
generateSW strategy error

imagen
injectManifest strategy error


Tip

The author of this PR can publish a preview release by commenting /publish below.

Copy link

netlify bot commented Sep 4, 2024

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 7460340
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/66d864123cad99000878223f
😎 Deploy Preview https://deploy-preview-750--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin
Copy link
Member Author

userquin commented Sep 4, 2024

/publish

Copy link

pkg-pr-new bot commented Sep 4, 2024

pnpm add https://pkg.pr.new/vite-plugin-pwa@750

commit: 7460340

@userquin userquin changed the title feat(injectManifest)!: optimize workbox load feat(injectManifest): optimize workbox load Sep 4, 2024
@userquin userquin merged commit 6db1873 into main Sep 4, 2024
6 checks passed
@userquin userquin deleted the userquin/feat-optimize-workbox-load branch September 4, 2024 13:47
renovate bot added a commit to SebastianGoeb/chinese-chart that referenced this pull request Sep 9, 2024
This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | Type |
Update |
|---|---|---|---|---|---|---|---|
|
[@tailwindcss/forms](https://redirect.github.com/tailwindlabs/tailwindcss-forms)
| [`0.5.8` ->
`0.5.9`](https://renovatebot.com/diffs/npm/@tailwindcss%2fforms/0.5.8/0.5.9)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@tailwindcss%2fforms/0.5.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@tailwindcss%2fforms/0.5.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@tailwindcss%2fforms/0.5.8/0.5.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@tailwindcss%2fforms/0.5.8/0.5.9?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin)
([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin))
| [`8.3.0` ->
`8.4.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.3.0/8.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2feslint-plugin/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2feslint-plugin/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2feslint-plugin/8.3.0/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2feslint-plugin/8.3.0/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
|
[@typescript-eslint/parser](https://typescript-eslint.io/packages/parser)
([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser))
| [`8.3.0` ->
`8.4.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.3.0/8.4.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/@typescript-eslint%2fparser/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/@typescript-eslint%2fparser/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/@typescript-eslint%2fparser/8.3.0/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/@typescript-eslint%2fparser/8.3.0/8.4.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | minor |
|
[JamesIves/github-pages-deploy-action](https://redirect.github.com/JamesIves/github-pages-deploy-action)
| `v4.6.3` -> `v4.6.4` |
[![age](https://developer.mend.io/api/mc/badges/age/github-tags/JamesIves%2fgithub-pages-deploy-action/v4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/github-tags/JamesIves%2fgithub-pages-deploy-action/v4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/github-tags/JamesIves%2fgithub-pages-deploy-action/v4.6.3/v4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/github-tags/JamesIves%2fgithub-pages-deploy-action/v4.6.3/v4.6.4?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| action | patch |
| [postcss](https://postcss.org/)
([source](https://redirect.github.com/postcss/postcss)) | [`8.4.43` ->
`8.4.45`](https://renovatebot.com/diffs/npm/postcss/8.4.43/8.4.45) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/postcss/8.4.45?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/postcss/8.4.45?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/postcss/8.4.43/8.4.45?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/postcss/8.4.43/8.4.45?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
| [vite](https://vitejs.dev)
([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite))
| [`5.4.2` ->
`5.4.3`](https://renovatebot.com/diffs/npm/vite/5.4.2/5.4.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/vite/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite/5.4.2/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite/5.4.2/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| overrides | patch |
| [vite](https://vitejs.dev)
([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite))
| [`5.4.2` ->
`5.4.3`](https://renovatebot.com/diffs/npm/vite/5.4.2/5.4.3) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/vite/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite/5.4.2/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite/5.4.2/5.4.3?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |
|
[vite-plugin-pwa](https://redirect.github.com/vite-pwa/vite-plugin-pwa)
| [`0.20.2` ->
`0.20.5`](https://renovatebot.com/diffs/npm/vite-plugin-pwa/0.20.2/0.20.5)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/vite-plugin-pwa/0.20.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/vite-plugin-pwa/0.20.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/vite-plugin-pwa/0.20.2/0.20.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/vite-plugin-pwa/0.20.2/0.20.5?slim=true)](https://docs.renovatebot.com/merge-confidence/)
| devDependencies | patch |

---

### Release Notes

<details>
<summary>tailwindlabs/tailwindcss-forms
(@&#8203;tailwindcss/forms)</summary>

###
[`v0.5.9`](https://redirect.github.com/tailwindlabs/tailwindcss-forms/blob/HEAD/CHANGELOG.md#059---2024-09-05)

[Compare
Source](https://redirect.github.com/tailwindlabs/tailwindcss-forms/compare/v0.5.8...v0.5.9)

##### Fixed

- Fallback to static chevron color if theme is using variables
([#&#8203;167](https://redirect.github.com/tailwindlabs/tailwindcss-forms/pull/167))

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/eslint-plugin)</summary>

###
[`v8.4.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#840-2024-09-02)

[Compare
Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.3.0...v8.4.0)

This was a version bump only for eslint-plugin to align it with other
projects, there were no code changes.

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

<details>
<summary>typescript-eslint/typescript-eslint
(@&#8203;typescript-eslint/parser)</summary>

###
[`v8.4.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#840-2024-09-02)

[Compare
Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.3.0...v8.4.0)

This was a version bump only for parser to align it with other projects,
there were no code changes.

You can read about our [versioning
strategy](https://main--typescript-eslint.netlify.app/users/versioning)
and
[releases](https://main--typescript-eslint.netlify.app/users/releases)
on our website.

</details>

<details>
<summary>JamesIves/github-pages-deploy-action
(JamesIves/github-pages-deploy-action)</summary>

###
[`v4.6.4`](https://redirect.github.com/JamesIves/github-pages-deploy-action/releases/tag/v4.6.4)

[Compare
Source](https://redirect.github.com/JamesIves/github-pages-deploy-action/compare/v4.6.3...v4.6.4)

<!-- Release notes generated using configuration in .github/release.yml
at releases/v4 -->

#### What's Changed

#### What's Changed

##### Bug Fixes 🐝

- fix: resolved an issue where the default config was not being applied
to the non-action version of the project.

##### Build 🔧

- build(deps): bump actions/checkout from 3 to 4 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[JamesIves/github-pages-deploy-action#1639
- build(deps): bump the misc group across 1 directory with 6 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[JamesIves/github-pages-deploy-action#1642
- build(deps): bump the misc group across 1 directory with 8 updates by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[JamesIves/github-pages-deploy-action#1648
- build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 in the misc group
by [@&#8203;dependabot](https://redirect.github.com/dependabot) in
[JamesIves/github-pages-deploy-action#1649
- build(deps): bump micromatch from 4.0.4 to 4.0.8 by
[@&#8203;dependabot](https://redirect.github.com/dependabot) in
[JamesIves/github-pages-deploy-action#1679

**Full Changelog**:
JamesIves/github-pages-deploy-action@v4...v4.6.4

</details>

<details>
<summary>postcss/postcss (postcss)</summary>

###
[`v8.4.45`](https://redirect.github.com/postcss/postcss/blob/HEAD/CHANGELOG.md#8445)

[Compare
Source](https://redirect.github.com/postcss/postcss/compare/8.4.44...8.4.45)

-   Removed unnecessary fix which could lead to infinite loop.

###
[`v8.4.44`](https://redirect.github.com/postcss/postcss/blob/HEAD/CHANGELOG.md#8444)

[Compare
Source](https://redirect.github.com/postcss/postcss/compare/8.4.43...8.4.44)

-   Another way to fix `markClean is not a function` error.

</details>

<details>
<summary>vitejs/vite (vite)</summary>

###
[`v5.4.3`](https://redirect.github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small)

[Compare
Source](https://redirect.github.com/vitejs/vite/compare/v5.4.2...v5.4.3)

- fix: allow getting URL of JS files in publicDir
([#&#8203;17915](https://redirect.github.com/vitejs/vite/issues/17915))
([943ece1](https://redirect.github.com/vitejs/vite/commit/943ece177e7709b3ba574e810afce347c51d4442)),
closes
[#&#8203;17915](https://redirect.github.com/vitejs/vite/issues/17915)
- fix: cjs warning respect the logLevel flag
([#&#8203;17993](https://redirect.github.com/vitejs/vite/issues/17993))
([dc3c14f](https://redirect.github.com/vitejs/vite/commit/dc3c14f39fcd57867c8ae81b75ae768b53b4b880)),
closes
[#&#8203;17993](https://redirect.github.com/vitejs/vite/issues/17993)
- fix: improve CJS warning trace information
([#&#8203;17926](https://redirect.github.com/vitejs/vite/issues/17926))
([5c5f82c](https://redirect.github.com/vitejs/vite/commit/5c5f82c84bb64309875b42eee9d4dd525ab42e8c)),
closes
[#&#8203;17926](https://redirect.github.com/vitejs/vite/issues/17926)
- fix: only remove entry assets handled by Vite core
([#&#8203;17916](https://redirect.github.com/vitejs/vite/issues/17916))
([ebfaa7e](https://redirect.github.com/vitejs/vite/commit/ebfaa7e6019783f308db5e759a6a67abb7cc626c)),
closes
[#&#8203;17916](https://redirect.github.com/vitejs/vite/issues/17916)
- fix: waitForRequestIdle locked
([#&#8203;17982](https://redirect.github.com/vitejs/vite/issues/17982))
([ad13760](https://redirect.github.com/vitejs/vite/commit/ad1376018a94b42540a8488d897cc520849e1228)),
closes
[#&#8203;17982](https://redirect.github.com/vitejs/vite/issues/17982)
- fix(css): fix directory index import in sass modern api
([#&#8203;17960](https://redirect.github.com/vitejs/vite/issues/17960))
([9b001ba](https://redirect.github.com/vitejs/vite/commit/9b001baa70c8489ac5550107c110a5dca281cda4)),
closes
[#&#8203;17960](https://redirect.github.com/vitejs/vite/issues/17960)
- fix(css): fix sass `file://` reference
([#&#8203;17909](https://redirect.github.com/vitejs/vite/issues/17909))
([561b940](https://redirect.github.com/vitejs/vite/commit/561b940f6f963fbb78058a6e23b4adad53a2edb9)),
closes
[#&#8203;17909](https://redirect.github.com/vitejs/vite/issues/17909)
- fix(css): fix sass modern source map
([#&#8203;17938](https://redirect.github.com/vitejs/vite/issues/17938))
([d428e7e](https://redirect.github.com/vitejs/vite/commit/d428e7e3a05f8da5ea00bb1b6a0827a5cc225899)),
closes
[#&#8203;17938](https://redirect.github.com/vitejs/vite/issues/17938)
- fix(deps): bump tsconfck
([#&#8203;17990](https://redirect.github.com/vitejs/vite/issues/17990))
([8c661b2](https://redirect.github.com/vitejs/vite/commit/8c661b20e92f33eb2e3ba3841b20dd6f6076f1ef)),
closes
[#&#8203;17990](https://redirect.github.com/vitejs/vite/issues/17990)
- fix(html): rewrite assets url in <template>
([#&#8203;17988](https://redirect.github.com/vitejs/vite/issues/17988))
([413c86a](https://redirect.github.com/vitejs/vite/commit/413c86aa971bc1ad8958578c929f45a368799f74)),
closes
[#&#8203;17988](https://redirect.github.com/vitejs/vite/issues/17988)
- fix(preload): add crossorigin attribute in CSS link tags
([#&#8203;17930](https://redirect.github.com/vitejs/vite/issues/17930))
([15871c7](https://redirect.github.com/vitejs/vite/commit/15871c75e0722adeda23f771fd6c45fecba4d118)),
closes
[#&#8203;17930](https://redirect.github.com/vitejs/vite/issues/17930)
- chore: reduce diffs with v6 branch
([#&#8203;17942](https://redirect.github.com/vitejs/vite/issues/17942))
([bf9065a](https://redirect.github.com/vitejs/vite/commit/bf9065aa13da6a519014c3bc1d34cfb1cb49ccca)),
closes
[#&#8203;17942](https://redirect.github.com/vitejs/vite/issues/17942)
- chore(deps): update all non-major dependencies
([#&#8203;17945](https://redirect.github.com/vitejs/vite/issues/17945))
([cfb621e](https://redirect.github.com/vitejs/vite/commit/cfb621e7a5a3e24d710a9af156e6855e73caf891)),
closes
[#&#8203;17945](https://redirect.github.com/vitejs/vite/issues/17945)
- chore(deps): update all non-major dependencies
([#&#8203;17991](https://redirect.github.com/vitejs/vite/issues/17991))
([0ca53cf](https://redirect.github.com/vitejs/vite/commit/0ca53cff9ff49108fcec75ff01d2445f9c2f2a4c)),
closes
[#&#8203;17991](https://redirect.github.com/vitejs/vite/issues/17991)

</details>

<details>
<summary>vite-pwa/vite-plugin-pwa (vite-plugin-pwa)</summary>

###
[`v0.20.5`](https://redirect.github.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.20.5)

[Compare
Source](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.4...v0.20.5)

#####    🐞 Bug Fixes

- Dev sw stop working when using generateSW strategy  -  by
[@&#8203;userquin](https://redirect.github.com/userquin) in
[vite-pwa/vite-plugin-pwa#751
[<samp>(9a9c3)</samp>](https://redirect.github.com/vite-pwa/vite-plugin-pwa/commit/9a9c390)

#####     [View changes on
GitHub](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.4...v0.20.5)

###
[`v0.20.4`](https://redirect.github.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.20.4)

[Compare
Source](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.3...v0.20.4)

#####    🚀 Features

- **injectManifest**: Optimize workbox load  -  by
[@&#8203;userquin](https://redirect.github.com/userquin) in
[vite-pwa/vite-plugin-pwa#750
[<samp>(6db18)</samp>](https://redirect.github.com/vite-pwa/vite-plugin-pwa/commit/6db1873)

#####     [View changes on
GitHub](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.3...v0.20.4)

###
[`v0.20.3`](https://redirect.github.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.20.3)

[Compare
Source](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.2...v0.20.3)

*No significant changes: add `git+` prefix to repository url*

#####     [View changes on
GitHub](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.2...v0.20.3)

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

👻 **Immortal**: This PR will be recreated if closed unmerged. Get
[config
help](https://redirect.github.com/renovatebot/renovate/discussions) if
that's undesired.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR was generated by [Mend Renovate](https://mend.io/renovate/).
View the [repository job
log](https://developer.mend.io/github/SebastianGoeb/chinese-chart).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize loading workbox::injectManifest
1 participant