fix: dev sw stop working when using generateSW strategy #751
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
renovate bot
added a commit
to SebastianGoeb/chinese-chart
that referenced
this pull request
Sep 9, 2024
This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | Type | Update | |---|---|---|---|---|---|---|---| | [@tailwindcss/forms](https://redirect.github.com/tailwindlabs/tailwindcss-forms) | [`0.5.8` -> `0.5.9`](https://renovatebot.com/diffs/npm/@tailwindcss%2fforms/0.5.8/0.5.9) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [@typescript-eslint/eslint-plugin](https://typescript-eslint.io/packages/eslint-plugin) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin)) | [`8.3.0` -> `8.4.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2feslint-plugin/8.3.0/8.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [@typescript-eslint/parser](https://typescript-eslint.io/packages/parser) ([source](https://redirect.github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser)) | [`8.3.0` -> `8.4.0`](https://renovatebot.com/diffs/npm/@typescript-eslint%2fparser/8.3.0/8.4.0) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | minor | | [JamesIves/github-pages-deploy-action](https://redirect.github.com/JamesIves/github-pages-deploy-action) | `v4.6.3` -> `v4.6.4` | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | action | patch | | [postcss](https://postcss.org/) ([source](https://redirect.github.com/postcss/postcss)) | [`8.4.43` -> `8.4.45`](https://renovatebot.com/diffs/npm/postcss/8.4.43/8.4.45) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [vite](https://vitejs.dev) ([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.4.2` -> `5.4.3`](https://renovatebot.com/diffs/npm/vite/5.4.2/5.4.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | overrides | patch | | [vite](https://vitejs.dev) ([source](https://redirect.github.com/vitejs/vite/tree/HEAD/packages/vite)) | [`5.4.2` -> `5.4.3`](https://renovatebot.com/diffs/npm/vite/5.4.2/5.4.3) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | | [vite-plugin-pwa](https://redirect.github.com/vite-pwa/vite-plugin-pwa) | [`0.20.2` -> `0.20.5`](https://renovatebot.com/diffs/npm/vite-plugin-pwa/0.20.2/0.20.5) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | [](https://docs.renovatebot.com/merge-confidence/) | devDependencies | patch | --- ### Release Notes <details> <summary>tailwindlabs/tailwindcss-forms (@​tailwindcss/forms)</summary> ### [`v0.5.9`](https://redirect.github.com/tailwindlabs/tailwindcss-forms/blob/HEAD/CHANGELOG.md#059---2024-09-05) [Compare Source](https://redirect.github.com/tailwindlabs/tailwindcss-forms/compare/v0.5.8...v0.5.9) ##### Fixed - Fallback to static chevron color if theme is using variables ([#​167](https://redirect.github.com/tailwindlabs/tailwindcss-forms/pull/167)) </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/eslint-plugin)</summary> ### [`v8.4.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/eslint-plugin/CHANGELOG.md#840-2024-09-02) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.3.0...v8.4.0) This was a version bump only for eslint-plugin to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>typescript-eslint/typescript-eslint (@​typescript-eslint/parser)</summary> ### [`v8.4.0`](https://redirect.github.com/typescript-eslint/typescript-eslint/blob/HEAD/packages/parser/CHANGELOG.md#840-2024-09-02) [Compare Source](https://redirect.github.com/typescript-eslint/typescript-eslint/compare/v8.3.0...v8.4.0) This was a version bump only for parser to align it with other projects, there were no code changes. You can read about our [versioning strategy](https://main--typescript-eslint.netlify.app/users/versioning) and [releases](https://main--typescript-eslint.netlify.app/users/releases) on our website. </details> <details> <summary>JamesIves/github-pages-deploy-action (JamesIves/github-pages-deploy-action)</summary> ### [`v4.6.4`](https://redirect.github.com/JamesIves/github-pages-deploy-action/releases/tag/v4.6.4) [Compare Source](https://redirect.github.com/JamesIves/github-pages-deploy-action/compare/v4.6.3...v4.6.4) <!-- Release notes generated using configuration in .github/release.yml at releases/v4 --> #### What's Changed #### What's Changed ##### Bug Fixes 🐝 - fix: resolved an issue where the default config was not being applied to the non-action version of the project. ##### Build 🔧 - build(deps): bump actions/checkout from 3 to 4 by [@​dependabot](https://redirect.github.com/dependabot) in [JamesIves/github-pages-deploy-action#1639 - build(deps): bump the misc group across 1 directory with 6 updates by [@​dependabot](https://redirect.github.com/dependabot) in [JamesIves/github-pages-deploy-action#1642 - build(deps): bump the misc group across 1 directory with 8 updates by [@​dependabot](https://redirect.github.com/dependabot) in [JamesIves/github-pages-deploy-action#1648 - build(deps-dev): bump ts-jest from 29.2.2 to 29.2.3 in the misc group by [@​dependabot](https://redirect.github.com/dependabot) in [JamesIves/github-pages-deploy-action#1649 - build(deps): bump micromatch from 4.0.4 to 4.0.8 by [@​dependabot](https://redirect.github.com/dependabot) in [JamesIves/github-pages-deploy-action#1679 **Full Changelog**: JamesIves/github-pages-deploy-action@v4...v4.6.4 </details> <details> <summary>postcss/postcss (postcss)</summary> ### [`v8.4.45`](https://redirect.github.com/postcss/postcss/blob/HEAD/CHANGELOG.md#8445) [Compare Source](https://redirect.github.com/postcss/postcss/compare/8.4.44...8.4.45) - Removed unnecessary fix which could lead to infinite loop. ### [`v8.4.44`](https://redirect.github.com/postcss/postcss/blob/HEAD/CHANGELOG.md#8444) [Compare Source](https://redirect.github.com/postcss/postcss/compare/8.4.43...8.4.44) - Another way to fix `markClean is not a function` error. </details> <details> <summary>vitejs/vite (vite)</summary> ### [`v5.4.3`](https://redirect.github.com/vitejs/vite/blob/HEAD/packages/vite/CHANGELOG.md#small543-2024-09-03-small) [Compare Source](https://redirect.github.com/vitejs/vite/compare/v5.4.2...v5.4.3) - fix: allow getting URL of JS files in publicDir ([#​17915](https://redirect.github.com/vitejs/vite/issues/17915)) ([943ece1](https://redirect.github.com/vitejs/vite/commit/943ece177e7709b3ba574e810afce347c51d4442)), closes [#​17915](https://redirect.github.com/vitejs/vite/issues/17915) - fix: cjs warning respect the logLevel flag ([#​17993](https://redirect.github.com/vitejs/vite/issues/17993)) ([dc3c14f](https://redirect.github.com/vitejs/vite/commit/dc3c14f39fcd57867c8ae81b75ae768b53b4b880)), closes [#​17993](https://redirect.github.com/vitejs/vite/issues/17993) - fix: improve CJS warning trace information ([#​17926](https://redirect.github.com/vitejs/vite/issues/17926)) ([5c5f82c](https://redirect.github.com/vitejs/vite/commit/5c5f82c84bb64309875b42eee9d4dd525ab42e8c)), closes [#​17926](https://redirect.github.com/vitejs/vite/issues/17926) - fix: only remove entry assets handled by Vite core ([#​17916](https://redirect.github.com/vitejs/vite/issues/17916)) ([ebfaa7e](https://redirect.github.com/vitejs/vite/commit/ebfaa7e6019783f308db5e759a6a67abb7cc626c)), closes [#​17916](https://redirect.github.com/vitejs/vite/issues/17916) - fix: waitForRequestIdle locked ([#​17982](https://redirect.github.com/vitejs/vite/issues/17982)) ([ad13760](https://redirect.github.com/vitejs/vite/commit/ad1376018a94b42540a8488d897cc520849e1228)), closes [#​17982](https://redirect.github.com/vitejs/vite/issues/17982) - fix(css): fix directory index import in sass modern api ([#​17960](https://redirect.github.com/vitejs/vite/issues/17960)) ([9b001ba](https://redirect.github.com/vitejs/vite/commit/9b001baa70c8489ac5550107c110a5dca281cda4)), closes [#​17960](https://redirect.github.com/vitejs/vite/issues/17960) - fix(css): fix sass `file://` reference ([#​17909](https://redirect.github.com/vitejs/vite/issues/17909)) ([561b940](https://redirect.github.com/vitejs/vite/commit/561b940f6f963fbb78058a6e23b4adad53a2edb9)), closes [#​17909](https://redirect.github.com/vitejs/vite/issues/17909) - fix(css): fix sass modern source map ([#​17938](https://redirect.github.com/vitejs/vite/issues/17938)) ([d428e7e](https://redirect.github.com/vitejs/vite/commit/d428e7e3a05f8da5ea00bb1b6a0827a5cc225899)), closes [#​17938](https://redirect.github.com/vitejs/vite/issues/17938) - fix(deps): bump tsconfck ([#​17990](https://redirect.github.com/vitejs/vite/issues/17990)) ([8c661b2](https://redirect.github.com/vitejs/vite/commit/8c661b20e92f33eb2e3ba3841b20dd6f6076f1ef)), closes [#​17990](https://redirect.github.com/vitejs/vite/issues/17990) - fix(html): rewrite assets url in <template> ([#​17988](https://redirect.github.com/vitejs/vite/issues/17988)) ([413c86a](https://redirect.github.com/vitejs/vite/commit/413c86aa971bc1ad8958578c929f45a368799f74)), closes [#​17988](https://redirect.github.com/vitejs/vite/issues/17988) - fix(preload): add crossorigin attribute in CSS link tags ([#​17930](https://redirect.github.com/vitejs/vite/issues/17930)) ([15871c7](https://redirect.github.com/vitejs/vite/commit/15871c75e0722adeda23f771fd6c45fecba4d118)), closes [#​17930](https://redirect.github.com/vitejs/vite/issues/17930) - chore: reduce diffs with v6 branch ([#​17942](https://redirect.github.com/vitejs/vite/issues/17942)) ([bf9065a](https://redirect.github.com/vitejs/vite/commit/bf9065aa13da6a519014c3bc1d34cfb1cb49ccca)), closes [#​17942](https://redirect.github.com/vitejs/vite/issues/17942) - chore(deps): update all non-major dependencies ([#​17945](https://redirect.github.com/vitejs/vite/issues/17945)) ([cfb621e](https://redirect.github.com/vitejs/vite/commit/cfb621e7a5a3e24d710a9af156e6855e73caf891)), closes [#​17945](https://redirect.github.com/vitejs/vite/issues/17945) - chore(deps): update all non-major dependencies ([#​17991](https://redirect.github.com/vitejs/vite/issues/17991)) ([0ca53cf](https://redirect.github.com/vitejs/vite/commit/0ca53cff9ff49108fcec75ff01d2445f9c2f2a4c)), closes [#​17991](https://redirect.github.com/vitejs/vite/issues/17991) </details> <details> <summary>vite-pwa/vite-plugin-pwa (vite-plugin-pwa)</summary> ### [`v0.20.5`](https://redirect.github.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.20.5) [Compare Source](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.4...v0.20.5) ##### 🐞 Bug Fixes - Dev sw stop working when using generateSW strategy - by [@​userquin](https://redirect.github.com/userquin) in [vite-pwa/vite-plugin-pwa#751 [<samp>(9a9c3)</samp>](https://redirect.github.com/vite-pwa/vite-plugin-pwa/commit/9a9c390) ##### [View changes on GitHub](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.4...v0.20.5) ### [`v0.20.4`](https://redirect.github.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.20.4) [Compare Source](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.3...v0.20.4) ##### 🚀 Features - **injectManifest**: Optimize workbox load - by [@​userquin](https://redirect.github.com/userquin) in [vite-pwa/vite-plugin-pwa#750 [<samp>(6db18)</samp>](https://redirect.github.com/vite-pwa/vite-plugin-pwa/commit/6db1873) ##### [View changes on GitHub](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.3...v0.20.4) ### [`v0.20.3`](https://redirect.github.com/vite-pwa/vite-plugin-pwa/releases/tag/v0.20.3) [Compare Source](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.2...v0.20.3) *No significant changes: add `git+` prefix to repository url* ##### [View changes on GitHub](https://redirect.github.com/vite-pwa/vite-plugin-pwa/compare/v0.20.2...v0.20.3) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "before 4am on Monday" (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://redirect.github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/SebastianGoeb/chinese-chart). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC41OS4yIiwidXBkYXRlZEluVmVyIjoiMzguNTkuMiIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Missing version when generating the sw with dev options enabled.
Linked Issues
Additional Context
Tip
The author of this PR can publish a preview release by commenting
/publishbelow.