Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to latest eslint config #600

Merged
merged 5 commits into from
Nov 25, 2023
Merged

chore: upgrade to latest eslint config #600

merged 5 commits into from
Nov 25, 2023

Conversation

antfu
Copy link
Member

@antfu antfu commented Nov 20, 2023

The new config improves the consistent in quite many places

Copy link

netlify bot commented Nov 20, 2023

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit fbd2e18
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/65613c59c51b9900088a675a
😎 Deploy Preview https://deploy-preview-600--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@userquin

This comment was marked as resolved.

@userquin
Copy link
Member

Seems to be another problem, tsup preserving process.node.NODE_ENV in options module.

@antfu
Copy link
Member Author

antfu commented Nov 20, 2023

Oh that's unintentional, fixed

# Conflicts:
#	examples/preact-router/tsconfig.json
#	examples/react-router/tsconfig.json
#	examples/solid-router/tsconfig.json
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx 🎉

@userquin userquin merged commit 194fb59 into main Nov 25, 2023
3 checks passed
@userquin userquin deleted the chore/eslint-config branch November 25, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants