Skip to content

update algolia to use spanish and not english #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 6, 2023
Merged

update algolia to use spanish and not english #412

merged 2 commits into from
Jun 6, 2023

Conversation

marcterradas
Copy link
Contributor

Hello Vite team. 🙂
I see in the Spanish documentation that the search button is in English, so I create this pull request to update the algolia button to Spanish.

I see that in Chinese documentation is translated, so I copied the configuration from the Chinese repo and updated with the Spanish translation.

Link from the Chinese documentation: https://github.com/vitejs/docs-cn/blob/main/.vitepress/config.ts#LL71C9-L71C22

Hope this can help.

@netlify
Copy link

netlify bot commented Jun 6, 2023

Deploy Preview for vite-docs-es ready!

Name Link
🔨 Latest commit 3fdec4b
🔍 Latest deploy log https://app.netlify.com/sites/vite-docs-es/deploys/647f5d5c37edbb0008b3c52a
😎 Deploy Preview https://deploy-preview-412--vite-docs-es.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@mrcego
Copy link
Member

mrcego commented Jun 6, 2023

Hola @marcterradas. Muchas gracias. Está bien traducido, debería revisar también por que no funciona el buscador 🤔.

Algún tip por donde empezar, @patak-dev? Sorry por el ping.

@marcterradas
Copy link
Contributor Author

si necesitáis ayuda os puedo ayudar, igualmente esta pull request en principio no afecta, he mirado en producción https://es.vitejs.dev/ y tampoco funciona, creamos una issue y lo trabajamos en otra pull request?

@mrcego
Copy link
Member

mrcego commented Jun 6, 2023

si necesitáis ayuda os puedo ayudar, igualmente esta pull request en principio no afecta, he mirado en producción https://es.vitejs.dev/ y tampoco funciona, creamos una issue y lo trabajamos en otra pull request?

Apruebo entonces esta y relacionamos. Gracias nuevamente @marcterradas.

@mrcego mrcego merged commit 7926d9e into vitejs:main Jun 6, 2023
@vitejs vitejs locked and limited conversation to collaborators Jun 6, 2023
@marcterradas marcterradas deleted the new-translation branch June 6, 2023 16:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants