feat: vite repo #120
Merged
feat: vite repo #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patak-dev
approved these changes
Aug 28, 2022
Member
patak-dev
left a comment
patak-dev
left a comment
There was a problem hiding this comment.
Oh, this is amazing, thanks so much for implementing this feature. It has been a pain not being able to run ecosystem-ci on every PR we want.
About the options, I was wondering if we should have repo be https://github.com/vitejs/vite to allow not GitHub repositories but given that all PRs will come from other GitHub repos, I think we should go with your current choice and keep it simple.
Collaborator
|
Nice! Should we add reading package json and comparing the package name to ensure it is a vite fork? |
Member
Author
Implemented 👍 This should help to notice that we have tried to use a different repository. |
9 tasks
dominikg
reviewed
Aug 29, 2022
dominikg
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for using repository other than vitejs/vite.
Example run: https://github.com/sapphi-red/vite-ecosystem-ci/runs/8059305521?check_suite_focus=true#step:7:11
closes #33