Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: optional --commit flag #339

Merged
merged 1 commit into from
Nov 28, 2024
Merged

Conversation

Aslemammad
Copy link
Contributor

if the commit flag is empty or absent, we'd just avoid passing it so we also avoid unexpected errors!

@dominikg dominikg merged commit cd992a8 into vitejs:main Nov 28, 2024
1 check passed
@bluwy
Copy link
Member

bluwy commented Nov 29, 2024

FYI the workflow is failing now with this change: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/12077745828

@Aslemammad
Copy link
Contributor Author

FYI the workflow is failing now with this change: https://github.com/vitejs/vite-ecosystem-ci/actions/runs/12077745828

Sorry for that, will have a look right now!

@Aslemammad
Copy link
Contributor Author

hope this works! #340

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants