feat: add support for non-dev jsx runtime #224
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I stumble across an issue where the Fast Refresh feature doesn't work with a Vite plugin I'm maintaining. After examination, I identified the root cause: The generated code with
.js
extension usesreact/jsx-runtime
for JSX transformation instead ofreact/jsx-dev-runtime
, because of this, the generated code is no longer eligible for applying Fest Refresh, which results in a full page reloaded.Here is a JS file generated by the compiler, for example (click to expand)
Filename:
Res.bs.js
In order to fix it, this PR adds an extra check for such case so that the Fast Refresh works as expected.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).