Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused function parameter #56

Merged
merged 3 commits into from
Aug 16, 2023
Merged

chore: remove unused function parameter #56

merged 3 commits into from
Aug 16, 2023

Conversation

holazz
Copy link
Contributor

@holazz holazz commented Dec 13, 2022 •
edited
Loading

Description

Since we don't need to get the hash from the source, there is no need to pass it.

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@haoqunjiang haoqunjiang merged commit 28bb84b into vitejs:main Aug 16, 2023
@holazz holazz deleted the chore/vue-jsx branch August 17, 2023 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@holazz @bluwy @haoqunjiang