refactor: simplify array handling (#5734)

vitejs · Nov 18, 2021 · 2cacc6b · 2cacc6b
1 parent dcaaa0f
commit 2cacc6b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 9 deletions.
diff --git a/packages/plugin-vue/src/template.ts b/packages/plugin-vue/src/template.ts
@@ -134,11 +134,7 @@ export function resolveTemplateCompilerOptions(
 
   if (transformAssetUrls && typeof transformAssetUrls === 'object') {
     // presence of array fields means this is raw tags config
-    if (
-      Object.keys(transformAssetUrls).some((key) =>
-        Array.isArray((transformAssetUrls as any)[key])
-      )
-    ) {
+    if (Object.values(transformAssetUrls).some((val) => Array.isArray(val))) {
       transformAssetUrls = {
         ...assetUrlOptions,
         tags: transformAssetUrls as any

diff --git a/packages/vite/src/client/client.ts b/packages/vite/src/client/client.ts
@@ -78,10 +78,8 @@ async function handleMessage(payload: HMRPayload) {
           // can't use querySelector with `[href*=]` here since the link may be
           // using relative paths so we need to use link.href to grab the full
           // URL for the include check.
-          const el = (
-            [].slice.call(
-              document.querySelectorAll(`link`)
-            ) as HTMLLinkElement[]
+          const el = Array.from(
+            document.querySelectorAll<HTMLLinkElement>('link')
           ).find((e) => e.href.includes(path))
           if (el) {
             const newPath = `${base}${path.slice(1)}${