fix: warn when publicDir and outDir are nested (#13742)

Co-authored-by: Bjorn Lu <bjornlu.dev@gmail.com>
vitejs · Jul 17, 2023 · 4eb3154 · 4eb3154
1 parent c971f26
commit 4eb3154
Showing 1 changed file with 19 additions and 0 deletions.
diff --git a/packages/vite/src/node/build.ts b/packages/vite/src/node/build.ts
@@ -753,6 +753,19 @@ function prepareOutDir(
       config.publicDir &&
       fs.existsSync(config.publicDir)
     ) {
+      if (!areSeparateFolders(outDir, config.publicDir)) {
+        config.logger.warn(
+          colors.yellow(
+            `\n${colors.bold(
+              `(!)`,
+            )} The public directory feature may not work correctly. outDir ${colors.white(
+              colors.dim(outDir),
+            )} and publicDir ${colors.white(
+              colors.dim(config.publicDir),
+            )} are not separate folders.\n`,
+          ),
+        )
+      }
       copyDir(config.publicDir, outDir)
     }
   }
@@ -1223,3 +1236,9 @@ export function toOutputFilePathWithoutRuntime(
 
 export const toOutputFilePathInCss = toOutputFilePathWithoutRuntime
 export const toOutputFilePathInHtml = toOutputFilePathWithoutRuntime
+
+function areSeparateFolders(a: string, b: string) {
+  const na = normalizePath(a)
+  const nb = normalizePath(b)
+  return na !== nb && !na.startsWith(nb + '/') && !nb.startsWith(na + '/')
+}