fix: disable fs.cachedChecks for custom watch ignore patterns (#15828)

vitejs · Feb 7, 2024 · 9070be3 · 9070be3
1 parent 1c0dc3d
commit 9070be3
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 6 deletions.
diff --git a/packages/vite/src/node/fsUtils.ts b/packages/vite/src/node/fsUtils.ts
@@ -45,9 +45,13 @@ const cachedFsUtilsMap = new WeakMap<ResolvedConfig, FsUtils>()
 export function getFsUtils(config: ResolvedConfig): FsUtils {
   let fsUtils = cachedFsUtilsMap.get(config)
   if (!fsUtils) {
-    if (config.command !== 'serve' || !config.server.fs.cachedChecks) {
-      // cached fsUtils is only used in the dev server for now, and only when the watcher isn't configured
-      // we can support custom ignored patterns later
+    if (
+      config.command !== 'serve' ||
+      config.server.fs.cachedChecks === false ||
+      config.server.watch?.ignored
+    ) {
+      // cached fsUtils is only used in the dev server for now
+      // it is enabled by default only when there aren't custom watcher ignored patterns configured
       fsUtils = commonFsUtils
     } else if (
       !config.resolve.preserveSymlinks &&

diff --git a/packages/vite/src/node/server/index.ts b/packages/vite/src/node/server/index.ts
@@ -194,10 +194,10 @@ export interface FileSystemServeOptions {
   deny?: string[]
 
   /**
-   * Enable caching of fs calls.
+   * Enable caching of fs calls. It is enabled by default if no custom watch ignored patterns are provided.
    *
    * @experimental
-   * @default true
+   * @default undefined
    */
   cachedChecks?: boolean
 }
@@ -1002,7 +1002,7 @@ export function resolveServerOptions(
     strict: server.fs?.strict ?? true,
     allow: allowDirs,
     deny,
-    cachedChecks: server.fs?.cachedChecks ?? true,
+    cachedChecks: server.fs?.cachedChecks,
   }
 
   if (server.origin?.endsWith('/')) {