fix: rewrite should only serve cache if upstream is 304

vitejs · Apr 27, 2020 · c3a7a96 · c3a7a96
1 parent 881b50a
commit c3a7a96
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/src/node/serverPluginModules.ts b/src/node/serverPluginModules.ts
@@ -66,7 +66,7 @@ export const modulesPlugin: Plugin = ({ root, app, watcher, resolver }) => {
       // only need to rewrite for <script> part in vue files
       !((ctx.path.endsWith('.vue') || ctx.vue) && ctx.query.type != null)
     ) {
-      if (rewriteCache.has(ctx.url)) {
+      if (ctx.status === 304 && rewriteCache.has(ctx.url)) {
         debugImportRewrite(`${ctx.url}: serving from cache`)
         ctx.body = rewriteCache.get(ctx.url)
       } else {
@@ -99,6 +99,7 @@ export const modulesPlugin: Plugin = ({ root, app, watcher, resolver }) => {
     // special handling for vue's runtime.
     if (id === 'vue') {
       const vuePath = resolveVue(root).vue
+      debugger
       await cachedRead(ctx, vuePath)
       debugModuleResolution(`vue -> ${getDebugPath(vuePath)}`)
       return