feat(build): set hoistTransitiveImports to false in library builds (#…

…15595)

packages/vite/src/node/__tests__/build.spec.ts

@@ -1,4 +1,4 @@
-import { resolve } from 'node:path'
+import { basename, resolve } from 'node:path'
 import { fileURLToPath } from 'node:url'
 import colors from 'picocolors'
 import { describe, expect, test, vi } from 'vitest'
@@ -102,6 +102,51 @@ describe('build', () => {
     ])
     assertOutputHashContentChange(result[0], result[1])
   })
+
+  test('external modules should not be hoisted in library build', async () => {
+    const [esBundle] = (await build({
+      logLevel: 'silent',
+      build: {
+        lib: {
+          entry: ['foo.js', 'bar.js'],
+          formats: ['es'],
+        },
+        rollupOptions: {
+          external: 'external',
+        },
+        write: false,
+      },
+      plugins: [
+        {
+          name: 'test',
+          resolveId(id) {
+            const name = basename(id)
+            if (name === 'foo.js' || name === 'bar.js') {
+              return name
+            }
+          },
+          load(id) {
+            if (id === 'foo.js') {
+              return `
+                  import bar from 'bar.js'
+                  export default bar()
+                `
+            }
+            if (id === 'bar.js') {
+              return `
+                  import ext from 'external';
+                  export default ext();`
+            }
+          },
+        },
+      ],
+    })) as RollupOutput[]
+
+    const foo = esBundle.output.find(
+      (chunk) => chunk.fileName === 'foo.js',
+    ) as OutputChunk
+    expect(foo.code).not.contains('import "external"')
+  })
 })
 
 const baseLibOptions: LibraryOptions = {

packages/vite/src/node/build.ts

@@ -603,6 +603,7 @@ export async function build(
         exports: 'auto',
         sourcemap: options.sourcemap,
         name: libOptions ? libOptions.name : undefined,
+        hoistTransitiveImports: libOptions ? false : undefined,
         // es2015 enables `generatedCode.symbols`
         // - #764 add `Symbol.toStringTag` when build es module into cjs chunk
         // - #1048 add `Symbol.toStringTag` for module default export