Skip to content

Commit

Permalink
fix: if host is specified check whether it is valid (#14013)
Browse files Browse the repository at this point in the history
  • Loading branch information
btea authored and bluwy committed Oct 3, 2023
1 parent 65df270 commit eda46c3
Showing 1 changed file with 12 additions and 2 deletions.
14 changes: 12 additions & 2 deletions packages/vite/src/node/cli.ts
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,16 @@ function cleanOptions<Options extends GlobalCLIOptions>(
return ret
}

/**
* host may be a number (like 0), should convert to string
*/
const convertHost = (v: any) => {
if (typeof v === 'number') {
return String(v)
}
return v
}

cli
.option('-c, --config <file>', `[string] use specified config file`)
.option('--base <path>', `[string] public base path (default: /)`)
Expand All @@ -116,7 +126,7 @@ cli
.command('[root]', 'start dev server') // default command
.alias('serve') // the command is called 'serve' in Vite's API
.alias('dev') // alias to align with the script name
.option('--host [host]', `[string] specify hostname`)
.option('--host [host]', `[string] specify hostname`, { type: [convertHost] })
.option('--port <port>', `[number] specify port`)
.option('--https', `[boolean] use TLS + HTTP/2`)
.option('--open [path]', `[boolean | string] open browser on startup`)
Expand Down Expand Up @@ -306,7 +316,7 @@ cli
// preview
cli
.command('preview [root]', 'locally preview production build')
.option('--host [host]', `[string] specify hostname`)
.option('--host [host]', `[string] specify hostname`, { type: [convertHost] })
.option('--port <port>', `[number] specify port`)
.option('--strictPort', `[boolean] exit if specified port is already in use`)
.option('--https', `[boolean] use TLS + HTTP/2`)
Expand Down

0 comments on commit eda46c3

Please sign in to comment.