import(/* @vite-ignore */) is not worked in *.ts for v4

[igisev]

Describe the bug

In v4.0.1 the comment /* @vite-ignore */ is ignored for import(/* @vite-ignore */)

let url = `/dynamic/${file}.js`;
// ...
import(url);                      // <- case1: warning expected
import(/* @vite-ignore */ url);   // <- case2: no warning expected

Run npx vite.
In case1 and case2 a warning will be issued:

The above dynamic import cannot be analyzed by Vite.
See https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations for supported dynamic import formats. If this is intended to be left as-is, you can use the /* @vite-ignore */ comment inside the import() call to suppress this warning.

NOTE: for v3.2.5 case2 without warning.

Reproduction

https://github.com/rollup/plugins/tree/master/packages/dynamic-import-vars#limitations
https://stackblitz.com/edit/vitejs-vite-tyj1xj?file=main.ts&terminal=dev

Steps to reproduce

No response

System Info

System:
    OS: Windows 10 10.0.22621
    CPU: (16) x64 AMD Ryzen 7 5800X 8-Core Processor
    Memory: 19.09 GB / 31.93 GB
  Binaries:
    Node: 16.18.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.19.2 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.22621.963.0), Chromium (108.0.1462.46)
    Internet Explorer: 11.0.22621.1
  npmPackages:
    @vitejs/plugin-vue: 4.0.0 => 4.0.0
    vite: 4.0.1 => 4.0.1

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[github-actions]

Hello @igisev. Please provide a minimal reproduction using a GitHub repository or StackBlitz. Issues marked with need reproduction will be closed if they have no activity within 3 days.

[patak-dev]

Please help us by creating a real reproduction, you can use https://vite.new for it. Thanks!

[igisev]

minimal reproduction
https://stackblitz.com/edit/vitejs-vite-tyj1xj?file=main.ts&terminal=dev

[igisev]

I found that warning is only in ts-files, not in js-files

[antfu]

It seems the comment has been removed on transpiling from TS to JS.

[bluwy]

Looks like it was (sort-of) a breaking change introduced in esbuild 0.15.17 (evanw/esbuild#2439). The issue in general is tracked at evanw/esbuild#2721

[bluwy]

This is fixed in esbuild v0.16.14