Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: clean up preTransformRequest #12672

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Mar 31, 2023

Description

Clean up preTransformRequest handling a bit.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

@bluwy bluwy added the p1-chore Doesn't change code behavior (priority) label Mar 31, 2023
@stackblitz
Copy link

stackblitz bot commented Mar 31, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Comment on lines -279 to +278
const staticImportedUrls = new Set<{ url: string; id: string }>()
const staticImportedUrls = new Set<string>()
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're only tracking the url now

server.config.logger.error(e)
server.config.logger.error(e.message)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed this to e.message to be consistent with import analysis. I also find this to be sufficient for pre-transform errors instead of logging the whole thing.

@patak-dev patak-dev merged commit 561227c into main Mar 31, 2023
@patak-dev patak-dev deleted the refactor-transform-request branch March 31, 2023 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p1-chore Doesn't change code behavior (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants