refactor: clean up preTransformRequest #12672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
commented
Mar 31, 2023
Comment on lines
-279
to
+278
| const staticImportedUrls = new Set<{ url: string; id: string }>() | ||
| const staticImportedUrls = new Set<string>() |
There was a problem hiding this comment.
We're only tracking the url now
| server.config.logger.error(e) | ||
| server.config.logger.error(e.message) |
There was a problem hiding this comment.
Changed this to e.message to be consistent with import analysis. I also find this to be sufficient for pre-transform errors instead of logging the whole thing.
patak-dev
approved these changes
Mar 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Clean up
preTransformRequesthandling a bit.Additional context
What is the purpose of this pull request?