Internal rollup crash when transform generates invalid js

[manucorporat]

Describe the bug

When a plugin incorrectly transform JS code into invalid JS code, instead of showing the actual parsing error. It makes rollup crash in the error augmentation code.

Seems like an bug shared between rollup and vite. The error augmentation code should use the sourceCode as the last transform. Not the original source code.

> vite build

vite v4.3.9 building for production...
✓ 3 modules transformed.
✓ built in 85ms
[vite:build-import-analysis] Cannot destructure property 'line' of 'locate(...)' as it is undefined.
file: /home/projects/vitejs-vite-5cun7m/counter.js
error during build:
TypeError: Cannot destructure property 'line' of 'locate(...)' as it is undefined.
    at augmentCodeLocation (file://file:///home/projects/vitejs-vite-5cun7m/node_modules/rollup/dist/es/shared/node-entry.js:2250:17)
    at Object.error (file://file:///home/projects/vitejs-vite-5cun7m/node_modules/rollup/dist/es/shared/node-entry.js:23856:25)
    at Object.transform (file://file:///home/projects/vitejs-vite-5cun7m/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:45130:22)
 ELIFECYCLE  Command failed with exit code 1.

Reproduction

https://stackblitz.com/edit/vitejs-vite-5cun7m?file=main.js,integrations.vscode.userData.settingsRaw,vite.config.js,counter.js,index.html&terminal=dev

Steps to reproduce

pnpm run build

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (8) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.19 - /usr/local/bin/yarn
    npm: 9.4.2 - /usr/local/bin/npm
  npmPackages:
    vite: ^4.3.9 => 4.3.9

Used Package Manager

npm

Logs

> vite build

vite v4.3.9 building for production...
✓ 3 modules transformed.
✓ built in 85ms
[vite:build-import-analysis] Cannot destructure property 'line' of 'locate(...)' as it is undefined.
file: /home/projects/vitejs-vite-5cun7m/counter.js
error during build:
TypeError: Cannot destructure property 'line' of 'locate(...)' as it is undefined.
    at augmentCodeLocation (file://file:///home/projects/vitejs-vite-5cun7m/node_modules/rollup/dist/es/shared/node-entry.js:2250:17)
    at Object.error (file://file:///home/projects/vitejs-vite-5cun7m/node_modules/rollup/dist/es/shared/node-entry.js:23856:25)
    at Object.transform (file://file:///home/projects/vitejs-vite-5cun7m/node_modules/vite/dist/node/chunks/dep-e8f070e8.js:45130:22)
 ELIFECYCLE  Command failed with exit code 1.

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[bolt-new-by-stackblitz]

Start a new pull request in StackBlitz Codeflow.

• vitejs-vite-5cun7m (Open reproduction)

[bluwy]

Should this be reported to Rollup instead? The code where it errors is at https://github.com/rollup/rollup/blob/833314c1621420e031340c1894e7863e062f7761/src/utils/error.ts#L50

[manucorporat]

Rollup has a problematic code path, but the root of the problem is somehow vite now allowing rollup to get the updated currentSource across transforms, so the error is augmented incorrectly.

I cant reproduce this issue only with rollup.

[manucorporat]

The fix in rollup:
rollup/rollup#5045

would prevent the crash, but it would silence completely the error augmentation