fix: use string manipulation instead of regex to inject esbuild helpers #14094
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #14065 lib mode hanging for umd build, by using string manipulation instead of regex
Additional context
The original fix #7948 used regex for string replacement to avoid global esbuild helpers.
It has since caused multiple performance issues #8738 #8099 #10900 #14065, and received numerous attempts #8110 #8741 #10905 at fixing it, but there're still unhandled cases:
I think this shows that regex isn't the right solution in this scenario. It's easier to manipulate the string directly, at the cost of a few extra lines.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).