Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry pick for v4 #14520

Merged
merged 20 commits into from
Oct 3, 2023
Merged

chore: cherry pick for v4 #14520

merged 20 commits into from
Oct 3, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Oct 3, 2023

Description

Cherry picked these commits/PRs (oldest to newest):

Additional context

Focused on downstream blockers and minor bug fixes, and a bit relaxed with picking these. The only commits I'm unsure of are the sourcemap fixes since we changed sourcemap handling quite a bit, so I didn't picked those.

Let me know if there's more to pick, or commits that you think shouldn't be picked.

Also make sure to rebase and merge!

sapphi-red and others added 19 commits October 3, 2023 14:05
…literals (#14458)

Co-authored-by: 翠 / green <green@sapphi.red>
@patak-dev
Copy link
Member

/ecosystem-ci run

@vite-ecosystem-ci
Copy link

vite-ecosystem-ci bot commented Oct 3, 2023

📝 Ran ecosystem CI: Open

suite result
analogjs ✅ success
astro ✅ success
histoire ✅ success
ladle ✅ success
laravel ✅ success
marko ✅ success
nuxt ✅ success
nx ✅ success
previewjs ✅ success
qwik ✅ success
rakkas ✅ success
sveltekit ✅ success
unocss ✅ success
vike ✅ success
vite-plugin-pwa ✅ success
vite-plugin-react ✅ success
vite-plugin-react-pages ✅ success
vite-plugin-react-swc ✅ success
vite-plugin-svelte ✅ success
vite-plugin-vue ✅ success
vite-setup-catalogue ✅ success
vitepress ✅ success
vitest ✅ success

patak-dev
patak-dev previously approved these changes Oct 3, 2023
Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for porting all these! Sounds good to me. Let's wait until after ViteConf to release Vite 4.4.10.

@bluwy
Copy link
Member Author

bluwy commented Oct 3, 2023

Looks like there's some CI fails. Gonna check that. EDIT: Looks like macos is a fluke, and windows needs to pin to 18.17

I'm not sure if we need to wait till ViteConf though, they are mostly bug fixes. If ecosystem-ci is mostly passing I think we can cut a new patch soon.

@bluwy
Copy link
Member Author

bluwy commented Oct 3, 2023

Looks like Rakkas is the only one failing. I re-ran it just in case it's a fluke. I'll also cherry-pick the node 18.17 pin to v4 directly so that this PR's CI will pass when merged.

@sapphi-red
Copy link
Member

sapphi-red commented Oct 3, 2023

Thanks!

I think it's safer to restore this part so that the edge case in the comment works.
4b1c92d#diff-071a32aedd2ea59472ebb69fb456e818b103d1a332da632e12c2d54395938ad1L91-L107

@sapphi-red
Copy link
Member

Given that the ecosystem-ci is passing, I think we can release the patch when it's ready.

@bluwy
Copy link
Member Author

bluwy commented Oct 3, 2023

Good catch! I forgot there's a partial breaking change there. Will push another commit to bring it back.

@bluwy bluwy merged commit f8b9adb into v4 Oct 3, 2023
8 checks passed
@bluwy bluwy deleted the cherry-pick-v4 branch October 3, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.