-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: cherry pick for v4 #14520
chore: cherry pick for v4 #14520
Conversation
…literals (#14458) Co-authored-by: 翠 / green <green@sapphi.red>
/ecosystem-ci run |
📝 Ran ecosystem CI: Open
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for porting all these! Sounds good to me. Let's wait until after ViteConf to release Vite 4.4.10.
Looks like there's some CI fails. Gonna check that. EDIT: Looks like macos is a fluke, and windows needs to pin to 18.17 I'm not sure if we need to wait till ViteConf though, they are mostly bug fixes. If ecosystem-ci is mostly passing I think we can cut a new patch soon. |
Looks like Rakkas is the only one failing. I re-ran it just in case it's a fluke. I'll also cherry-pick the node 18.17 pin to |
Thanks! I think it's safer to restore this part so that the edge case in the comment works. |
Given that the ecosystem-ci is passing, I think we can release the patch when it's ready. |
Good catch! I forgot there's a partial breaking change there. Will push another commit to bring it back. |
Description
Cherry picked these commits/PRs (oldest to newest):
86cbf69 fix(glob): trigger HMR for glob in a package #14117
bd9b749 fix: ws never connects after restarting server if server.hmr.server is set #14127
387a6e8 fix: initWasm options should be optional #14152
c39e6c1 fix: if host is specified check whether it is valid #14013
91a18c2 fix: use string manipulation instead of regex to inject esbuild helpers #14094
627159d fix: handle sourcemap correctly when multiple line import exists #14232
245d186 fix(vite): precisely check if files are in dirs #14241
6f86de3 fix: add source map to Web Workers (fix #14216) #14217
34826aa fix(cli): convert special base #14283
2b80089 fix(css): remove pure css chunk sourcemap #14290
66a97be fix: include
vite/types/*
in exports field #14296c5f6558 fix(optimizer): define crawlDeps after scanProcessing and optimizationResult are complete (fix #14284) #14285
19bf0f1 fix(css): reset render cache on renderStart #14326
4bf31e5 fix(manifest): preserve pure css chunk assets #14297
9884308 feat: improve deno and bun support #14379
c3e4791 fix: handle errors during
hasWorkspacePackageJSON
function #1439499b0645 fix(import-analysis): preserve importedUrls import order #14465
ec7ee22 fix(analysis): warnings for dynamic imports that use static template literals #14458
f80ff77 fix(resolve): support submodules of optional peer deps #14489
Additional context
Focused on downstream blockers and minor bug fixes, and a bit relaxed with picking these. The only commits I'm unsure of are the sourcemap fixes since we changed sourcemap handling quite a bit, so I didn't picked those.
Let me know if there's more to pick, or commits that you think shouldn't be picked.
Also make sure to rebase and merge!