Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): convert special base #14283

Merged
merged 1 commit into from
Sep 4, 2023
Merged

fix(cli): convert special base #14283

merged 1 commit into from
Sep 4, 2023

Conversation

btea
Copy link
Collaborator

@btea btea commented Sep 4, 2023

Description

fix #14204

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Sep 4, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@bluwy bluwy merged commit 34826aa into vitejs:main Sep 4, 2023
@btea btea deleted the fix/convert-special-base branch September 4, 2023 09:56
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@btea @bluwy
fix(cli): convert special base (#14283)
c1db72a
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@btea @bluwy
fix(cli): convert special base (#14283)
d4bc0fb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bluwy bluwy bluwy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

building with --base "" results in /0 being used for the base instead
2 participants
@btea @bluwy