-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vite): precisely check if files are in dirs #14241
Merged
Merged
+77
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run & review this pull request in StackBlitz Codeflow. |
6 tasks
sapphi-red
added
the
p3-minor-bug
An edge case that only affects very specific usage (priority)
label
Aug 31, 2023
sapphi-red
approved these changes
Aug 31, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
patak-dev
approved these changes
Sep 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome ❤️
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
bluwy
pushed a commit
that referenced
this pull request
Oct 3, 2023
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Discovered when debugging nuxt/nuxt#20446, if the root starts with the same path as something being resolved - for example if the root is
/app
and we are resolve the id/app.vue
then we were not correctly prefixing the root directory to the incoming id.This particular example is an edge case and probably only likely to occur in a docker container where a folder that high up the fs tree is used for the source files of a project.
However, this PR contains a raft of similar fixes where we were checking for a directory prefix but not that this prefix was delimited with a trailing slash. I suspect these will be hit rarely but occasionally.
Strictly speaking, only the change in
packages/vite/src/node/plugins/resolve.ts
is needed to resolve the issue I linked.Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).