Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vite): precisely check if files are in dirs #14241

Merged
merged 6 commits into from
Sep 3, 2023

Conversation

danielroe
Copy link
Contributor

@danielroe danielroe commented Aug 30, 2023

Description

Discovered when debugging nuxt/nuxt#20446, if the root starts with the same path as something being resolved - for example if the root is /app and we are resolve the id /app.vue then we were not correctly prefixing the root directory to the incoming id.

This particular example is an edge case and probably only likely to occur in a docker container where a folder that high up the fs tree is used for the source files of a project.

However, this PR contains a raft of similar fixes where we were checking for a directory prefix but not that this prefix was delimited with a trailing slash. I suspect these will be hit rarely but occasionally.

Strictly speaking, only the change in packages/vite/src/node/plugins/resolve.ts is needed to resolve the issue I linked.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 30, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@danielroe danielroe marked this pull request as ready for review August 30, 2023 14:11
@sapphi-red sapphi-red added the p3-minor-bug An edge case that only affects very specific usage (priority) label Aug 31, 2023
Copy link
Member

@sapphi-red sapphi-red left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants