Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: add source map to Web Workers (fix #14216) #14217

Merged
merged 1 commit into from
Sep 3, 2023
Merged

fix: add source map to Web Workers (fix #14216) #14217

merged 1 commit into from
Sep 3, 2023

Conversation

yume-chan
Copy link
Contributor

Description

Generate source map in vite:worker plugin, so Web Workers in TypeScript can be correctly debugged using browser DevTools.

Fixes #14216

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@stackblitz
Copy link

stackblitz bot commented Aug 28, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@yume-chan yume-chan force-pushed the yume-chan/issue14216 branch from c07360d to 8e9e383 Compare August 28, 2023 09:44
@patak-dev patak-dev merged commit 6f86de3 into vitejs:main Sep 3, 2023
@yume-chan yume-chan deleted the yume-chan/issue14216 branch September 10, 2023 02:28
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@yume-chan @bluwy
fix: add source map to Web Workers (fix #14216) (#14217)
e6c89d7
@bluwy bluwy mentioned this pull request Oct 3, 2023
Merged
bluwy pushed a commit that referenced this pull request Oct 3, 2023
@yume-chan @bluwy
fix: add source map to Web Workers (fix #14216) (#14217)
df6f32f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@underfin underfin underfin approved these changes

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Web Workers in TypeScript have incorrect source map
3 participants
@yume-chan @patak-dev @underfin