Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(import-analysis): preserve importedUrls import order #14465

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Sep 25, 2023

Description

Fix withastro/astro#8044

In import analysis, we're transforming the imports populate importedUrls in parallel, causing it to be non-deterministic. This affects frameworks that crawl the module graph for CSS to populate the HTML to prevent FOUC, e.g. SvelteKit and Astro (afaia), causing the CSS order to be incorrect.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the PR Title Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label Sep 25, 2023
@stackblitz
Copy link

stackblitz bot commented Sep 25, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@Dunqing
Copy link
Contributor

Dunqing commented Sep 25, 2023

I've looked into this before. I thought it was intentional.

@bluwy
Copy link
Member Author

bluwy commented Sep 25, 2023

It was deterministic before #12754 so very likely unintentional here 😬 Though there is a point that Set shouldn't exactly be ordered, but I think it makes sense to ensure that as there's a usecase for it.

@patak-dev patak-dev merged commit 99b0645 into main Sep 26, 2023
9 checks passed
@patak-dev patak-dev deleted the fix-mod-imported-urls-order branch September 26, 2023 08:18
@bluwy bluwy mentioned this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tailwind added after my style block clearing all styles
3 participants