fix: update javascript mime type to text/javascript #15427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bluwy
commented
Dec 26, 2023
Comment on lines
+122
to
+125
| "peerDependenciesMeta": { | ||
| "acorn": { | ||
| "optional": true | ||
| } |
There was a problem hiding this comment.
Added this since Vitest v1 relies on acorn-walk and has this peer dep warning. The acorn dep in acorn-walk is only used for types.
Comment on lines
-60
to
-63
| // mrmime and mime-db is not released yet: https://github.com/jshttp/mime-db/commit/c9242a9b7d4bb25d7a0c9244adec74aeef08d8a1 | ||
| mrmime.mimes['aac'] = 'audio/aac' | ||
| // https://wiki.xiph.org/MIME_Types_and_File_Extensions#.opus_-_audio/ogg | ||
| mrmime.mimes['opus'] = 'audio/ogg' |
There was a problem hiding this comment.
Already included in new mrmime version
patches/sirv@2.0.4.patch
Outdated
Comment on lines
72
to
73
| export default function(dir?: string, opts?: Options): RequestHandler; No newline at end of file | ||
| export default function(dir?: string, opts?: Options): RequestHandler; |
There was a problem hiding this comment.
This file actually didn't have any change, except this new line, which latest pnpm patch seems to start adding.
bluwy
added
the
p3-downstream-blocker
|
/ecosystem-ci run |
bluwy
changed the title
|
📝 Ran ecosystem CI on
|
sapphi-red
requested changes
Dec 30, 2023
Co-authored-by: 翠 / green <green@sapphi.red>
sapphi-red
approved these changes
Jan 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
sirvandmrmime, which updates the javascript mime type totext/javascript(fromapplication/javascript). I figured to update it everywhere in our codebase too for consistency.Note that the HTML spec recommends using
text/javascriptinstead.application/javascriptis deprecated.Additionally mrmime v2: https://github.com/lukeed/mrmime/releases/tag/v2.0.0
Additional context
Needs to run ecosystem in case there's significant breakage to the changed mime type for js and mjs files.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).