Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): normalize html path #15554

Merged
merged 2 commits into from
Jan 11, 2024
Merged

Conversation

btea
Copy link
Collaborator

@btea btea commented Jan 10, 2024

Description

fix #15527

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 10, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@patak-dev
Copy link
Member

Would you add a test case for this one?

@patak-dev patak-dev added feat: html p3-minor-bug An edge case that only affects very specific usage (priority) labels Jan 10, 2024
@btea
Copy link
Collaborator Author

btea commented Jan 10, 2024

Would you add a test case for this one?

I will give it a try.

Copy link
Member

@patak-dev patak-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The normalized id is used in other places now, but I think that it is safer to use it everywhere and not only for the line that fixed the linked issue.

@patak-dev patak-dev merged commit d0d5938 into vitejs:main Jan 11, 2024
10 checks passed
@btea btea mentioned this pull request Jan 11, 2024
9 tasks
@btea btea deleted the fix/build-path-error branch January 12, 2024 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: html p3-minor-bug An edge case that only affects very specific usage (priority)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS in HTML (inline) fails to build
2 participants