Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: build inline css #15575

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

test: build inline css #15575

wants to merge 3 commits into from

Conversation

btea
Copy link
Collaborator

@btea btea commented Jan 11, 2024

Description

Supplement #15554.

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines, especially the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Update the corresponding documentation if needed.
  • Ideally, include relevant tests that fail without this PR but pass with it.

Copy link

stackblitz bot commented Jan 11, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@btea
Copy link
Collaborator Author

btea commented Jan 11, 2024

@patak-dev Hi, I tried to add a test, but an error occurred in ci. I don't know what to do next, I hope to get your guidance, thank you!

@patak-dev
Copy link
Member

@btea it would be better to add this directly to the css playground so we avoid creating too many of them.

Comment on lines +205 to +209
<style>
body {
background: red;
}
</style>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this be enough to trigger the issue? Or do we need input: { main: 'index.html' } to make the build fail in windows? Probably we need a new playground in that case although I don't know if we should add it only for testing this. I'll let other folks that have a window machine get involved here.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I tested locally that this issue will be triggered only if two conditions exist at the same time. Looking forward to your test results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants