-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: build inline css #15575
base: main
Are you sure you want to change the base?
test: build inline css #15575
Conversation
Run & review this pull request in StackBlitz Codeflow. |
@patak-dev Hi, I tried to add a test, but an error occurred in ci. I don't know what to do next, I hope to get your guidance, thank you! |
@btea it would be better to add this directly to the css playground so we avoid creating too many of them. |
2918220
to
3f54b65
Compare
<style> | ||
body { | ||
background: red; | ||
} | ||
</style> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't this be enough to trigger the issue? Or do we need input: { main: 'index.html' }
to make the build fail in windows? Probably we need a new playground in that case although I don't know if we should add it only for testing this. I'll let other folks that have a window machine get involved here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I tested locally that this issue will be triggered only if two conditions exist at the same time. Looking forward to your test results.
Description
Supplement #15554.
Additional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).