Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin-legacy] Legacy build for IE 11 contains hexadecimal RGBA notation #4930

Closed
7 tasks done
winterkind opened this issue Sep 14, 2021 · 0 comments · Fixed by #5132
Closed
7 tasks done

[plugin-legacy] Legacy build for IE 11 contains hexadecimal RGBA notation #4930

winterkind opened this issue Sep 14, 2021 · 0 comments · Fixed by #5132

Comments

@winterkind
Copy link

Describe the bug

In my legacy build for IE 11, the built CSS chunk contains hexadecimal RGBA notation, which IE 11 does not support. Unlike the JS files, no separate legacy chunk for CSS is built.

From what I read so far, since version 2.5 vite uses esbuild to minify CSS files. Through issue #4650 there was an enhancement to respect the given target configuration in the main build. However, nothing like that seems to exist for the configuration of the legacy build. Apologies if I am missing something obvious.

As a result, the styling in broken in IE 11.

Reproduction

  1. Clone from https://gitlab.com/winterkind/vite-svelte-ie11
  2. npm install
  3. npm run build
  4. Check the built CSS chunk in the dist folder. You will find hexadecimal RGBA notation, e.g. for background-color. In the source file this is in functional notation.

System Info

System:
    OS: Windows 10 10.0.19042
    CPU: (8) x64 Intel(R) Core(TM) i7-7820HQ CPU @ 2.90GHz
    Memory: 16.22 GB / 31.87 GB
  Binaries:
    Node: 14.17.4 - ~\AppData\Local\Volta\tools\image\node\14.17.4\node.EXE
    Yarn: 1.22.11 - ~\AppData\Local\Volta\tools\image\yarn\1.22.11\bin\yarn.CMD
    npm: 6.14.14 - ~\AppData\Local\Volta\tools\image\npm\6.14.14\bin\npm.CMD
  Browsers:
    Chrome: 93.0.4577.63
    Edge: Spartan (44.19041.1023.0), Chromium (93.0.961.47)
    Internet Explorer: 11.0.19041.906
  npmPackages:
    vite: ^2.5.7 => 2.5.7

Used Package Manager

npm

Logs

No response

Validations

@winterkind winterkind changed the title plugin-legacy: legacy build for IE 11 contains hexadecimal RGBA notation [plugin-legacy] Legacy build for IE 11 contains hexadecimal RGBA notation Sep 17, 2021
haoqunjiang added a commit to haoqunjiang/vite that referenced this issue Sep 29, 2021
patak-dev pushed a commit that referenced this issue Oct 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant