-
-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add build.cssTarget
option
#5132
Conversation
Should we call this |
Yeah, makes sense. |
build.cssMinifyTarget
optionbuild.cssTarget
option
Hi, may I ask what the label "on hold" means? No complaints, I am just the one who opened #4930 and trying to plan my next steps regarding it. |
We want to discuss the naming of the option with the rest of the team before merging. This PR is probably going to be part of next week's release. |
What is the final name after the discussion? I want to find a description of this configuration on the documentation. |
It will be |
Description
fixes #4746
fixes #5070
fixes #4930
Additional context
This option was discussed in previous meetings.
But I mistakenly thought #4658 had fixed the issue, so I didn't implement it until now.
The original PR made it possible to work around the issue in legacy browsers and projects without dynamic imports.
But in cases like #4746, if users target
chrome61
,import()
will be transformed byesbuild
torequire()
, leading to errors.So we have to add this new option.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).