[Bug report] importing dependencies by fs paths results in two different copies of the same module (Same as #2503)

[meteorlxy]

Describe the bug

Almost the same as #2503.

The only difference is that, node_modules is not inside vite root:

-import fooSymbol from './node_modules/foo'
+import fooSymbol from '../node_modules/foo'
-import barSymbol from './node_modules/bar'
+import barSymbol from '../node_modules/bar'

I've updated the reproduce repo -> https://github.com/meteorlxy/repro-vite-2503

@patak-dev I think it's not a regression. In fact I found that #2848 did not fully fix that issue at that time. I just remembered now to look further into this problem 😅

Reproduction

https://github.com/meteorlxy/repro-vite-2503

System Info

System:
    OS: Linux 5.10 Ubuntu 20.04.3 LTS (Focal Fossa)
    CPU: (24) x64 AMD Ryzen 9 3900X 12-Core Processor
    Memory: 21.89 GB / 24.98 GB
    Container: Yes
    Shell: 5.8 - /usr/bin/zsh
  Binaries:
    Node: 16.14.2 - /usr/local/lib/node/bin/node
    Yarn: 1.22.18 - /usr/local/lib/node/bin/yarn
    npm: 8.5.0 - /usr/local/lib/node/bin/npm
  npmPackages:
    vite: ^2.9.1 => 2.9.1

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to https://github.com/vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.

[meteorlxy]

UPDATE

cc @Bigfish8

I updated the reproduction repo with another case - importing from a sub directory in a bare import.

import fooSymbol from 'foo/foo'

export default fooSymbol

import fooSymbol from 'foo'

export default fooSymbol