Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3.0.0-alpha.5: missing types for es-module-lexer #8349

Closed
7 tasks done
benmccann opened this issue May 26, 2022 · 1 comment · Fixed by #8352
Closed
7 tasks done

3.0.0-alpha.5: missing types for es-module-lexer #8349

benmccann opened this issue May 26, 2022 · 1 comment · Fixed by #8352
Assignees
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)

Comments

@benmccann
Copy link
Collaborator

benmccann commented May 26, 2022

Describe the bug

Cannot find module 'es-module-lexer' or its corresponding type declarations.

These bugs happen frequently with new releases. E.g.:

I wonder if we could add a test which tries to check the types of a Vite project to verify that the types are built in a valid manner?

Reproduction

https://github.com/sveltejs/kit/tree/vite-3

System Info

Happens with:

  • Vite 3.0.0-alpha.4
  • Vite 3.0.0-alpha.5

Used Package Manager

pnpm

Logs

@sveltejs/kit:test: ../../node_modules/.pnpm/vite@3.0.0-alpha.5/node_modules/vite/dist/node/index.d.ts(26,23): error TS2307: Cannot find module 'es-module-lexer' or its corresponding type declarations.
@sveltejs/kit:test:  ELIFECYCLE  Test failed. See above for more details.

Validations

@patak-dev
Copy link
Member

@sapphi-red I think this is related to:

@patak-dev patak-dev added the p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority) label May 27, 2022
@sapphi-red sapphi-red self-assigned this May 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jun 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
p3-downstream-blocker Blocking the downstream ecosystem to work properly (priority)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants