Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy websocket requests being intercepted by hmr server #864

Closed
mspero opened this issue Sep 28, 2020 · 0 comments · Fixed by #865
Closed

Proxy websocket requests being intercepted by hmr server #864

mspero opened this issue Sep 28, 2020 · 0 comments · Fixed by #865
Labels
enhancement New feature or request

Comments

@mspero
Copy link

mspero commented Sep 28, 2020

I am trying to configure a proxy for http and websocket requests. It seems http requests are intercepted correctly by the proxy server, websocket requests however are not intercepted and the ws open requests remains pending forever. I've tracked the issue in the serverPluginHmr.js file. It seems the websocket server for hmr is handling the ws upgrade request but doing nothing since the request header 'sec-websocket-protocol' does not match 'vite-hmr'.

@underfin underfin added the enhancement New feature or request label Sep 29, 2020
underfin added a commit to rolldown/vite that referenced this issue Sep 29, 2020
underfin added a commit that referenced this issue Sep 29, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Jul 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants