esbuild.keepNames causes typescript closure/function to not be tree shaken

[Pyrolistical]

Describe the bug

When esbuild.keepNames is enabled tree shaking doesn't work with closure/functions written in typescript.

In my reproduction case I setup 4 functions

1. devOnlyClosure that starts with if (import.meta.env.PROD) return;
2. devOnlyFunction that starts with if (import.meta.env.PROD) return;
3. thisClosureIsNeverCalled that is never called
4. thisFunctionIsNeverCalled that is never called

From my main file, I import the first two functions can call them.

When I make a production build I expect no JavaScript bundle as both of the called functions are effectively empty and remaining closure/function is never called nor imported.

But what I end up getting is this:

var l = Object.defineProperty;
var e = (n, o) => l(n, 'name', { value: o, configurable: !0 });
var t = Object.defineProperty,
  r = e((n, o) => t(n, 'name', { value: o, configurable: !0 }), '__name');
const i = r(() => {}, 'devOnlyClosure');
function u() {}
e(u, 'devOnlyFunction');
r(u, 'devOnlyFunction');
function c() {
  console.log('imagine 10,000 lines of code');
}
e(c, 'thisFunctionIsNeverCalled');
r(c, 'thisFunctionIsNeverCalled');
i();

What is unexpected:

1. devOnlyClosure has been correctly transformed into an empty closure but still remains
2. The call to devOnlyClosure hasn't been removed
3. devOnlyFunction has been correctly transformed into an empty function but still remains
4. thisFunctionIsNeverCalled is never called but still remains
5. the functions have their .name assigned twice

What is strange:

• the call to devOnlyFunction was removed, but devOnlyClosure wasn't
• thisClosureIsNeverCalled was removed, but thisFunctionIsNeverCalled wasn't
• functions get double .name assignment, but closures only get one
• if functions.ts is renamed to be a javascript file functions.js, then production build returns empty correctly
• if esbuild.keepNames is turned off, then production build returns empty correctly

What I suspect is happening is the typescript file is fed through esbuild transform, then after rollup has created the bundle, it is fed through esbuild again to minify. This is why there is a double .name assignment.

Reproduction

https://stackblitz.com/edit/vitejs-vite-79hhqf?file=dist/assets/index.70f295b1.js

System Info

System:
    OS: Linux 5.0 undefined
    CPU: (4) x64 Intel(R) Core(TM) i9-9880H CPU @ 2.30GHz
    Memory: 0 Bytes / 0 Bytes
    Shell: 1.0 - /bin/jsh
  Binaries:
    Node: 16.14.2 - /usr/local/bin/node
    Yarn: 1.22.10 - /bin/yarn
    npm: 7.17.0 - /bin/npm
  npmPackages:
    vite: 3.0.0 => 3.0.0

Used Package Manager

npm

Logs

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that reports the same bug to avoid creating a duplicate.
• Make sure this is a Vite issue and not a framework-specific issue. For example, if it's a Vue SFC related bug, it should likely be reported to vuejs/core instead.
• Check that this is a concrete bug. For Q&A open a GitHub Discussion or join our Discord Chat Server.
• The provided reproduction is a minimal reproducible example of the bug.