Skip asset inlining for Git LFS placeholders

[MajorBreakfast]

Description

Vite by default automatically inlines assets that are below a specified size limit (build.assetsInlineLimit, docs).

Unfortunately, if the build system does not download the LFS files for increased build performance (e.g. Netlify), this means that Git LFS placeholder files, which are small, also get inlined even though they do not contain the actual file content.

Example Git LFS placeholder file:

version https://git-lfs.github.com/spec/v1
oid sha256:5c908e755763256d23fdf72665459361bfa6e9e0de8fe9de1c122f3db6708317
size 176336

Suggested solution

Detect whether a file is an LFS placeholder (e.g. by comparing its first line) and skip inlining for detected LFS placeholders.

Alternative

No response

Additional context

No response

Validations

• Follow our Code of Conduct
• Read the Contributing Guidelines.
• Read the docs.
• Check that there isn't already an issue that request the same feature to avoid creating a duplicate.

[bluwy]

This make sense to me. The change needed would be at

vite/packages/vite/src/node/plugins/asset.ts

Lines 425 to 434 in 31c2926

	if (
	config.build.lib ||
	(!file.endsWith('.svg') &&
	!file.endsWith('.html') &&
	content.length < Number(config.build.assetsInlineLimit))
	) {
	const mimeType = mrmime.lookup(file) ?? 'application/octet-stream'
	// base64 inlined as a string
	url = `data:${mimeType};base64,${content.toString('base64')}`
	} else {

I think as a start, we could simply check if it starts with version https://git-lfs.github.com/spec/v1 and bail. Tests for this could be tricky too so it should be fine without a test for now.

Also to confirm, if we do skip inlining it, would it properly served by default?

[github-actions]

Hello @MajorBreakfast. We like your proposal/feedback and would appreciate a contribution via a Pull Request by you or another community member. We thank you in advance for your contribution and are looking forward to reviewing it!

[MajorBreakfast]

@bluwy @patak-dev @sapphi-red Thanks for all the support in getting this shipped!