fix: read file error on path has url space encode #10090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }) | ||
| const result = await handler.call( | ||
| ctx as any, | ||
| rawId.replace(/%20/g, ' '), |
There was a problem hiding this comment.
can we just use decodeURI(rawId)
There was a problem hiding this comment.
There was a problem hiding this comment.
failed to pass the test using decodeURI, see #8498
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Possible fix for (#9917 )
The reason for this problem is node.js fs.readFile error when take the path with the space URL encode.
fix problem by replace %20 by space when resolve file path.
use replace method because of encodeURIComponent is unsafe (#8498)
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123).