Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-vite): support create-vite-extra #10214

Merged
merged 4 commits into from
Oct 14, 2022
Merged

feat(create-vite): support create-vite-extra #10214

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
13f7b9d
feat(create-vite): support create-vite-extra
bluwy Sep 23, 2022
a567995
chore: move under others
bluwy Sep 23, 2022
502665c
feat: add arrows for external cli
bluwy Sep 23, 2022
1370307
chore: merge main
bluwy Sep 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions packages/create-vite/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ type Framework = {
name: string
display: string
color: ColorFunc
variants: FrameworkVariant[]
customCommand?: string
variants?: FrameworkVariant[]
}
type FrameworkVariant = {
name: string
Expand Down Expand Up @@ -158,6 +159,12 @@ const FRAMEWORKS: Framework[] = [
customCommand: 'npm create svelte@latest TARGET_DIR'
}
]
},
{
name: 'others',
display: 'Others',
color: reset,
customCommand: 'npm create vite-extra@latest TARGET_DIR'
}
]

Expand Down Expand Up @@ -247,7 +254,7 @@ async function init() {
name: 'variant',
message: reset('Select a variant:'),
choices: (framework: Framework) =>
framework.variants.map((variant) => {
framework.variants?.map((variant) => {
const variantColor = variant.color
return {
title: variantColor(variant.display || variant.name),
Expand Down Expand Up @@ -279,14 +286,17 @@ async function init() {
}

// determine template
const template: string = variant || framework || argTemplate
const template: string = variant || framework?.name || argTemplate

const pkgInfo = pkgFromUserAgent(process.env.npm_config_user_agent)
const pkgManager = pkgInfo ? pkgInfo.name : 'npm'
const isYarn1 = pkgManager === 'yarn' && pkgInfo?.version.startsWith('1.')

const { customCommand } =
FRAMEWORKS.flatMap((f) => f.variants).find((v) => v.name === template) ?? {}
const customCommand =
FRAMEWORKS.find((f) => f.name === template)?.customCommand ??
FRAMEWORKS.flatMap((f) => f.variants).find((v) => v?.name === template)
?.customCommand

if (customCommand) {
const fullCustomCommand = customCommand
.replace('TARGET_DIR', targetDir)
Expand Down