Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve node/build.ts ut coverage #10786

Merged
merged 4 commits into from
Nov 17, 2022
Merged

Conversation

sun0day
Copy link
Member

@sun0day sun0day commented Nov 4, 2022

Description

improve node/build.ts ut coverage

  • statements 48.32% ⬆️
  • branches 74.35% ⬆️
  • functions 26.82% ⬆️
  • lines 48.32% ⬆️

Additional context


What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@sun0day
Copy link
Member Author

sun0day commented Nov 7, 2022

can you help review this PR at your convenience @patak-dev? Thx.

patak-dev
patak-dev previously approved these changes Nov 7, 2022
@patak-dev
Copy link
Member

Looks good to me @sun0day. Just in case, full coverage on unit tests isn't a goal currently as our main tests are focused on the e2e playgrounds. Where it makes sense, I think it is good to have though.

@sun0day
Copy link
Member Author

sun0day commented Nov 7, 2022

Looks good to me @sun0day. Just in case, full coverage on unit tests isn't a goal currently as our main tests are focused on the e2e playgrounds. Where it makes sense, I think it is good to have though.

got it

bluwy
bluwy previously approved these changes Nov 9, 2022
@bluwy
Copy link
Member

bluwy commented Nov 9, 2022

Looks like #9886 recently merged which added new unit tests too and causing merge conflicts.

@sun0day sun0day dismissed stale reviews from bluwy and patak-dev via 03396f8 November 9, 2022 02:17
@sun0day
Copy link
Member Author

sun0day commented Nov 9, 2022

Looks like #9886 recently merged which added new unit tests too and causing merge conflicts.

Resolved. Test serve CI step is unstable in node16&windows-latest. :(

@patak-dev patak-dev merged commit 411cc3d into vitejs:main Nov 17, 2022
fc pushed a commit to fc/vite that referenced this pull request Nov 23, 2022
test: improve `node/build.ts` ut coverage - statements 48.32% branches 74.35% functions 26.82% lines 48.32%
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants