-
-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: improve node/build.ts ut coverage #10786
Conversation
…s 74.35% functions 26.82% lines 48.32%
can you help review this PR at your convenience @patak-dev? Thx. |
Looks good to me @sun0day. Just in case, full coverage on unit tests isn't a goal currently as our main tests are focused on the e2e playgrounds. Where it makes sense, I think it is good to have though. |
got it |
Looks like #9886 recently merged which added new unit tests too and causing merge conflicts. |
Resolved. |
test: improve `node/build.ts` ut coverage - statements 48.32% branches 74.35% functions 26.82% lines 48.32%
Description
improve
node/build.ts
ut coverageAdditional context
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).