Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: dedupe the vue in client bundle by default #11032

Merged
merged 1 commit into from
Nov 22, 2022

Commits on Nov 22, 2022

  1. feat: dedupe the vue in client bundle by default

    Fixes vitejs#2443
    Fixes vitejs#7454
    
    It's already been set by default in Nuxt 3 for a while now nuxt/framework#6735
    So I think this change should be harmless.
    And technically it could be considered a fix than a feat.
    
    Nevertheless, it's better to ship it in v4 to minimize disruptions on
    the user side.
    
    Things that are not covered in this PR:
    1. SSR, because `resolve.dedupe` doesn't work for ESM build outputs, and
    the CommonJS version is kinda hacky, I think it's better to skip the
    config for SSR completely. Besides, most related issues are from the
    client side.
    2. #5958 isn't fixed by this PR.
    haoqunjiang committed Nov 22, 2022
    Configuration menu
    Copy the full SHA
    e073f5a View commit details
    Browse the repository at this point in the history