Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(css): fix css lang regex #11237

Merged
merged 1 commit into from
Dec 7, 2022
Merged

fix(css): fix css lang regex #11237

merged 1 commit into from
Dec 7, 2022

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Dec 7, 2022

Description

Forgot a remove a slash when refactoring string regex to // version 😅

Fix #10570 (reply in thread)

Additional context

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines and follow the Commit Convention.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@bluwy bluwy added the p4-important Violate documented behavior or significantly improves performance (priority) label Dec 7, 2022
bluwy
bluwy commented Dec 7, 2022
View reviewed changes
packages/vite/src/node/constants.ts
/\.(css|less|sass|scss|styl|stylus|pcss|postcss|sss)($|\\?)/
/\.(css|less|sass|scss|styl|stylus|pcss|postcss|sss)(?:$|\?)/
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the codebase and found that we don't use the second capture group, so added a ?: so it's stricter for now.

@patak-dev patak-dev enabled auto-merge (squash) December 7, 2022 10:11
@patak-dev patak-dev merged commit a55d0b3 into main Dec 7, 2022
@patak-dev patak-dev deleted the fix-css-regex branch December 7, 2022 10:12
futurGH pushed a commit to futurGH/vite that referenced this pull request Feb 26, 2023
@bluwy @futurGH
fix(css): fix css lang regex (vitejs#11237)
bf329be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patak-dev patak-dev patak-dev approved these changes

Assignees
No one assigned
Labels
p4-important Violate documented behavior or significantly improves performance (priority)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bluwy @patak-dev