refactor: simplify the transformIndexHtml utility function
#1147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victornpb
changed the title
|
Edit: There is no bug here, but I still think the original code is quite confusing, I hope I made it better without having to make it longer. |
aleclarson
approved these changes
Nov 26, 2020
aleclarson
changed the title
transformIndexHtml utility function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original function was very oddly written IMHO, I had to long stare at this code trying make sense of it, until I figured what it was supposed to do. So I tried to make it very straightforward and make the intent more clear.