fix: importmap should insert before module preload link #11492
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #11304.
Vite now moves the existing importmap before the first script. But in #11304, there's a modulepreload link declared after the importmap. After Vite's
postImportMapHook
, the order becamemodulepreload importmap script
but the correct order should beimportmap modulepreload script
, modulepreload should come after import otherwise it will throw an error.Additional context
The modulepreload link may not indicate the module declared in the importmap. But moving the importmap before all modulepreload link seems like an acceptable and no side effect practice.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).